[PATCH v2 0/9] drm/tyr: add debugfs support
Alvin Sun <[email protected]> Fri, 31 Jul 2026 01:05:38 +0800
| Newsgroups | dev.linux.lists.driver-core,org.freedesktop.lists.dri-devel,org.kernel.feeds.b4-sent,org.kernel.vger.rust-for-linux |
|---|---|
| Message-ID | <[email protected]> |
Add debugfs support for the Tyr DRM driver. The series adds a SeqShow trait for seq_file-backed debugfs files with lifecycle hooks, a DrmSeqShow adapter with DRM device lifecycle management, and a gpuvas debugfs file in Tyr exposing GPU VA space information. Additionally, fix a use-after-free in the DRM debugfs open/release paths where a device could be unregistered while a debugfs file remains open. This is based on drm-rust-next and depends on: [PATCH v10 0/7] drm/tyr: firmware loading and MCU boot support https://lore.kernel.org/r/[email protected] See the full dependency and commit history at [1]. Link: https://gitlab.freedesktop.org/panfrost/linux/-/issues/11 Link: https://gitlab.freedesktop.org/panfrost/linux/-/merge_requests/59 [1] Signed-off-by: Alvin Sun <[email protected]> --- Changes in v2: - Reworked the debugfs implementation per feedback from Danilo on v1: dropped the hazptr/revocable-based approach in favor of the DRM debugfs_init callback and generic seq_file abstractions. - Fixed a UAF in drm_debugfs where a device could be unregistered while a debugfs file remains open (drm_dev_get/put across file lifetime). - Link to v1: https://lore.kernel.org/r/[email protected] --- Alvin Sun (9): rust: seq_file: add as_raw() method rust: debugfs: add SeqShow trait and seq_file file operations rust: debugfs: add Entry::from_raw and ScopedDir::from_dentry drm: move debugfs_init after dev->registered is set rust: drm: add debugfs_init callback to Driver trait rust: drm: add DrmSeqShow seq_file adapter rust: drm: gpuvm: add dump_gpuva_info to UniqueRefGpuVm drm/tyr: add gpuvas debugfs file drm/debugfs: hold device reference for the lifetime of open files drivers/gpu/drm/drm_debugfs.c | 45 ++++++++++++++++--- drivers/gpu/drm/drm_drv.c | 5 +++ drivers/gpu/drm/tyr/debugfs.rs | 65 +++++++++++++++++++++++++++ drivers/gpu/drm/tyr/driver.rs | 16 +++++++ drivers/gpu/drm/tyr/fw.rs | 8 ++++ drivers/gpu/drm/tyr/tyr.rs | 1 + drivers/gpu/drm/tyr/vm.rs | 5 +++ rust/bindings/bindings_helper.h | 1 + rust/kernel/debugfs.rs | 35 ++++++++++++++- rust/kernel/debugfs/entry.rs | 15 ++++++- rust/kernel/debugfs/file_ops.rs | 97 +++++++++++++++++++++++++++++++++++++++++ rust/kernel/debugfs/traits.rs | 30 ++++++++++++- rust/kernel/drm/debugfs.rs | 49 +++++++++++++++++++++ rust/kernel/drm/device.rs | 36 ++++++++++++++- rust/kernel/drm/driver.rs | 11 +++++ rust/kernel/drm/gpuvm/mod.rs | 8 ++++ rust/kernel/drm/mod.rs | 1 + rust/kernel/seq_file.rs | 6 +++ 18 files changed, 422 insertions(+), 12 deletions(-) --- base-commit: 0ffc014cb2abfc79d161662b125e085b3e7107e7 change-id: 20260730-tyr-debugfs-v2-608cef77d6e9 Best regards, -- Alvin Sun <[email protected]>