[PATCH RFC 04/15] arm_mpam: Add support for memory controller MSC on DT platforms
Yin Li <[email protected]>
| Newsgroups | dev.linux.lists.driver-core,org.kernel.vger.linux-arm-msm,org.kernel.vger.linux-devicetree,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <20260811-mpam-resctrl-dt-knp-support-v1-4-ea6397bead59@oss.qualcomm.com> |
From: Shanker Donthineni <[email protected]> The MPAM DT path only handles cache MSCs. Memory-controller MSCs cannot be probed yet. Add support to discover memory-controller MSCs from the device tree: derive the component id from the NUMA node and create a 'memory' class RIS, and treat a memory parent as accessible from all CPUs. Signed-off-by: Shanker Donthineni <[email protected]> [ morse: split out of a bigger patch, added affinity piece ] Signed-off-by: James Morse <[email protected]> [ Yin Li: fix context offset conflicts caused by line number mismatches ] Signed-off-by: Yin Li <[email protected]> --- drivers/resctrl/mpam_devices.c | 56 +++++++++++++++++++++++++++++++----------- 1 file changed, 41 insertions(+), 15 deletions(-) diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c index 6f2854fe08ca..975ddab771b4 100644 --- a/drivers/resctrl/mpam_devices.c +++ b/drivers/resctrl/mpam_devices.c @@ -263,10 +263,12 @@ static int mpam_dt_parse_resource(struct mpam_msc *msc, struct device_node *np, u32 ris_idx) { int err = 0; - u32 level = 0; - unsigned long cache_id; + u32 class_id = 0; + unsigned long component_id = 0; struct device *dev = &msc->pdev->dev; + enum mpam_class_types type = MPAM_CLASS_UNKNOWN; struct device_node *cache __free(device_node) = NULL; + struct device_node *memory __free(device_node) = NULL; struct device_node *parent __free(device_node) = of_get_parent(np); if (of_device_is_compatible(np, "arm,mpam-cache")) { @@ -275,27 +277,48 @@ static int mpam_dt_parse_resource(struct mpam_msc *msc, struct device_node *np, dev_err_once(dev, "Failed to read phandle\n"); return -EINVAL; } + type = MPAM_CLASS_CACHE; + } else if (of_device_is_compatible(parent, "cache")) { cache = parent; + type = MPAM_CLASS_CACHE; + } else if (of_device_is_compatible(np, "arm,mpam-memory")) { + memory = of_parse_phandle(np, "arm,mpam-device", 0); + if (!memory) { + dev_err_once(dev, "Failed to read phandle\n"); + return -EINVAL; + } + type = MPAM_CLASS_MEMORY; + } else if (of_device_is_compatible(np, "arm,mpam-memory-controller-msc")) { + memory = parent; + type = MPAM_CLASS_MEMORY; } else { - /* For now, only caches are supported */ - cache = NULL; - return err; - } - - err = of_property_read_u32(cache, "cache-level", &level); - if (err) { - dev_err_once(dev, "Failed to read cache-level\n"); + /* + * For now, only caches and memory controllers are + * supported. + */ return err; } - cache_id = cache_of_calculate_id(cache); - if (cache_id == ~0) { - dev_err_once(dev, "Failed to calculate cache-id\n"); - return -ENOENT; + /* Determine the class and component ids, based on type. */ + if (type == MPAM_CLASS_CACHE) { + err = of_property_read_u32(cache, "cache-level", &class_id); + if (err) { + dev_err_once(dev, "Failed to read cache-level\n"); + return err; + } + component_id = cache_of_calculate_id(cache); + if (component_id == ~0) { + dev_err_once(dev, "Failed to calculate cache-id\n"); + return -ENOENT; + } + } else if (type == MPAM_CLASS_MEMORY) { + err = of_node_to_nid(np); + component_id = (err == NUMA_NO_NODE) ? 0 : err; + class_id = MPAM_CLASS_ID_DEFAULT; } - return mpam_ris_create(msc, ris_idx, MPAM_CLASS_CACHE, level, cache_id); + return mpam_ris_create(msc, ris_idx, type, class_id, component_id); } static int mpam_dt_parse_resources(struct mpam_msc *msc, void *ignored) @@ -2163,6 +2186,9 @@ static int update_msc_accessibility(struct mpam_msc *msc) if (of_device_is_compatible(parent, "cache")) { err = get_cpumask_from_cache(parent, &msc->accessibility); + } else if (of_device_is_compatible(parent, "memory")) { + cpumask_copy(&msc->accessibility, cpu_possible_mask); + err = 0; } else { err = -EINVAL; dev_err_once(dev, "Cannot determine accessibility of MSC.\n"); -- 2.34.1