Re: [PATCH v2] driver core: avoid klist_remove() on unattached knode_driver
Nguyen Quang Le Kien <[email protected]>
| Newsgroups | dev.linux.lists.driver-core,org.kernel.vger.linux-kernel,org.kernel.vger.linux-usb |
|---|---|
| Message-ID | <[email protected]> |
Hi Greg, v1 used klist_node_attached(&dev->p->knode_driver). v1 passed the syzbot test, but after reviewing the code again I realized klist_node_attached() isn't really the right check at that level -- it's a raw klist API. device_is_bound() is what driver core uses to ask whether a device is bound, and it also handles the NULL dev->p case. So I switched to that in v2. Nothing else changed. As for syzbot -- it's just where I find kernel bugs, and it can test my patches for me. That's all. Thanks, Kien