Re: [DTrace-devel] [PATCH 1/5] test: fix typos and clarify assertions

Reviewed-by: Eugene Loh <[email protected]>

On 8/13/25 11:57, Kris Van Hees via DTrace-devel wrote:
> Signed-off-by: Kris Van Hees <[email protected]>
> ---
>   test/unittest/actions/trace/tst.array-char-multi-nul.d     | 2 +-
>   test/unittest/actions/trace/tst.array-char-str-multi-nul.d | 2 +-
>   test/unittest/actions/trace/tst.array-char-str-no-nul.d    | 4 ++--
>   test/unittest/actions/trace/tst.array-char-str.d           | 2 +-
>   test/unittest/actions/trace/tst.array-char-unprintable.d   | 2 +-
>   5 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/test/unittest/actions/trace/tst.array-char-multi-nul.d b/test/unittest/actions/trace/tst.array-char-multi-nul.d
> index ae6370a4a..bd91498f3 100644
> --- a/test/unittest/actions/trace/tst.array-char-multi-nul.d
> +++ b/test/unittest/actions/trace/tst.array-char-multi-nul.d
> @@ -7,7 +7,7 @@
>   
>   /*
>    * ASSERTION: The trace() action prints a char-array of printable characters
> - *	      with multiple 0-bytes in its content.
> + *	      with multiple 0-bytes in its content as raw bytes.
>    *
>    * SECTION: Actions and Subroutines/trace()
>    */
> diff --git a/test/unittest/actions/trace/tst.array-char-str-multi-nul.d b/test/unittest/actions/trace/tst.array-char-str-multi-nul.d
> index 4734e619b..ba0435db8 100644
> --- a/test/unittest/actions/trace/tst.array-char-str-multi-nul.d
> +++ b/test/unittest/actions/trace/tst.array-char-str-multi-nul.d
> @@ -7,7 +7,7 @@
>   
>   /*
>    * ASSERTION: The trace() action prints a char-array of printable characters
> - *	      followed y by multiple 0-bytes correctly.
> + *	      followed by multiple 0-bytes correctly as a string.
>    *
>    * SECTION: Actions and Subroutines/trace()
>    */
> diff --git a/test/unittest/actions/trace/tst.array-char-str-no-nul.d b/test/unittest/actions/trace/tst.array-char-str-no-nul.d
> index c9acc4e73..48633a6cb 100644
> --- a/test/unittest/actions/trace/tst.array-char-str-no-nul.d
> +++ b/test/unittest/actions/trace/tst.array-char-str-no-nul.d
> @@ -6,8 +6,8 @@
>    */
>   
>   /*
> - * ASSERTION: The trace() action prints a char-aarray of printable characters
> - *	      (not terminated) correctly.
> + * ASSERTION: The trace() action prints a char-array of printable characters
> + *	      (not terminated) correctly as a string.
>    *
>    * SECTION: Actions and Subroutines/trace()
>    */
> diff --git a/test/unittest/actions/trace/tst.array-char-str.d b/test/unittest/actions/trace/tst.array-char-str.d
> index 465721b04..b61de776c 100644
> --- a/test/unittest/actions/trace/tst.array-char-str.d
> +++ b/test/unittest/actions/trace/tst.array-char-str.d
> @@ -7,7 +7,7 @@
>   
>   /*
>    * ASSERTION: The trace() action prints a char-array of printable characters
> - *	      (terminated) correctly.
> + *	      (terminated) correctly as a string.
>    *
>    * SECTION: Actions and Subroutines/trace()
>    */
> diff --git a/test/unittest/actions/trace/tst.array-char-unprintable.d b/test/unittest/actions/trace/tst.array-char-unprintable.d
> index 2fa5a1066..5b2525c35 100644
> --- a/test/unittest/actions/trace/tst.array-char-unprintable.d
> +++ b/test/unittest/actions/trace/tst.array-char-unprintable.d
> @@ -7,7 +7,7 @@
>   
>   /*
>    * ASSERTION: The trace() action prints a char-array with a non-printable
> - *	      character correctly.
> + *	      character correctly as raw bytes.
>    *
>    * SECTION: Actions and Subroutines/trace()
>    */