Re: [PATCH] Convert ip6_finish_output to rawfbt

On 26/08/2025 23:04, [email protected] wrote:
> From: Eugene Loh <[email protected]>
> 
> With commit fe2101e55 ("fbt: implement based on fentry/fexit probes")
> test/unittest/ip/tst.ipv6localicmp.sh started to fail.  The problem
> appears to be that fbt::ip6_finish_output:entry, which is needed for
> ip:::send, does not fire.
> 
> Use rawfbt for this probe to revert back to kprobes in this case.
> 
> Other fbt probes may also be impacted, but this case showed up in testing.
> 
> Signed-off-by: Eugene Loh <[email protected]>

Reviewed-by: Alan Maguire <[email protected]>

> ---
>  libdtrace/dt_prov_ip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libdtrace/dt_prov_ip.c b/libdtrace/dt_prov_ip.c
> index e09198061..5384346bd 100644
> --- a/libdtrace/dt_prov_ip.c
> +++ b/libdtrace/dt_prov_ip.c
> @@ -25,7 +25,7 @@ static probe_dep_t	probes[] = {
>  	{ "send",
>  	  DTRACE_PROBESPEC_NAME,	"fbt::ip_finish_output:entry" },
>  	{ "send",
> -	  DTRACE_PROBESPEC_NAME,	"fbt::ip6_finish_output:entry" },
> +	  DTRACE_PROBESPEC_NAME,	"rawfbt::ip6_finish_output:entry" },
>  	{ NULL, }
>  };
>