Re: [PATCH v2] trace: print alloca pointers as actual pointer values

On Fri, Sep 12, 2025 at 08:36:19PM -0400, Eugene Loh wrote:
> Similar comments to v1:
> 
> On 9/12/25 00:16, Kris Van Hees wrote:
> > Because alloca pointers are stored internally as ofssets into the
> 
> Again, s/ofssets/offsets/.
> 
> > scratchmem area, they were printed as small integers.  They are
> > now printed as actual pointer values into kernel space.
> 
> And again test failures.  This time, not with the new test, but as you say,
> "Ah, tehe joy of fixing one problem only to uncover another."  So this time:
> 
>         test/unittest/funcs/alloca/tst.alloca-funcs.d: FAIL: expected
> results differ.
>             Diff against expected:
>              a/b
>             -8b11/b/b3a/b//baba
>             +18446671313727729520b11/b/b3a/b//baba
> 
> Here, "8" has become "18446671313727729520".  So, need some .r change (and
> some .r.p magic and possibly .d tweak).

This is resolved by the other patch about subtracting pointers.  With both
patches, this failure is no longer.

>         test/unittest/funcs/alloca/tst.string-alloca.d: FAIL: expected
> results differ.
>             Diff against expected:
>             -abc
>             +
> 
> Here, simply a bug?

Hm...  This passed on my end somehow.  Let me look (perhaps I forgot to include
a change when I prepared the v2).