Re: [DTrace-devel] [PATCH v3] trace: print alloca pointers as actual pointer values
Eugene Loh <[email protected]>
| Newsgroups | dev.linux.lists.dtrace |
|---|---|
| Message-ID | <[email protected]> |
On 9/16/25 14:00, Kris Van Hees wrote: > On Tue, Sep 16, 2025 at 01:07:50PM -0400, Eugene Loh wrote: >> Just cleaning up my inbox... >> >> On 9/16/25 12:02, Kris Van Hees wrote: >> >>> On Tue, Sep 16, 2025 at 09:17:26AM -0400, Kris Van Hees wrote: >>>> Eugene: Can you test with my kvh/2.0-branch-dev branch from ca-tools4? >> Yeah. I get the same issues. >>> Ah, I just took my tree, and merged dev-queue into it, and now I am seeing the >>> issue pop up with tst.tid_pid.sh at least so will look at that right now. >> Cool. Let me know if you need something else. >>>> On Mon, Sep 15, 2025 at 11:20:28PM -0400, Kris Van Hees wrote: >>>>> Do you have the pointer subtraction patch applied before this one? >> Yes. > These are the failures I see: > > test/unittest/aggs/tst.aggmod_full2.sh: FAIL: erroneous exitcode (1). > test/unittest/builtinvar/tst.tid_pid.sh: FAIL: erroneous exitcode (1). > test/unittest/consumer/tst.merge_ranges_bug25767469.c: FAIL: erroneous exitcode (1). > test/unittest/consumer/tst.symbols.c: FAIL: erroneous exitcode (1). > test/unittest/version/err.1.1.d: FAIL: core dumped. > > Only the tid_pid one seems to be related to the alloca handling code in > store_val(). Agreed. > Do you see other failures in addition to this? Yes. See https://oss.oracle.com/pipermail/dtrace-devel/2025-September/006645.html . But I tried your fresh 2.0-branch-dev and it looked fine. So I suspect things are good now, but I'll try the full test suite and check.