Re: [PATCH] Add examples directory to installed doc directory

On 9/18/25 1:14 PM, Nick Alcock wrote:
> On 18 Sep 2025, Elena Zannoni uttered the following:
>
>> Make sure that the examples directory gets installed. 
>> It will be installed under /usr/share/doc/dtrace/examples.
>>
>>
>> Signed-off-by: Elena Zannoni <[email protected]>
> Reviewed-by: Nick Alcock <[email protected]>
>
> (Though this seems to be built on top of your previous commit -- I guess
> they'll get squashed together or something?)

No, they are separate patches, I used the same branch though, where I have that other local commit.

>> diff --git a/Build b/Build
>> index 1a66a824..220c9784 100644
>> --- a/Build
>> +++ b/Build
>> @@ -7,12 +7,18 @@ install::
>>  	mkdir -p $(INSTDOCDIR)/userguide/explanation
>>  	mkdir -p $(INSTDOCDIR)/userguide/how-to
>>  	mkdir -p $(INSTDOCDIR)/userguide/reference
>> -	$(call describe-install-target,$(INSTDOCDIR),README INCOMPATIBILITIES NEWS doc/userguide)
>> +	mkdir -p $(INSTDOCDIR)/examples/
>> +	mkdir -p $(INSTDOCDIR)/examples/language_features
> That first mkdir -p line is technically unnecessary (but harmless).

Ah ok

>> +	$(call describe-install-target,$(INSTDOCDIR),README INCOMPATIBILITIES NEWS userguide examples)
>>  	install -m 644 README INCOMPATIBILITIES NEWS $(INSTDOCDIR)
>>  	install -m 644 doc/userguide/index.md $(INSTDOCDIR)/userguide
>>  	install -m 644 doc/userguide/explanation/* $(INSTDOCDIR)/userguide/explanation
>>  	install -m 644 doc/userguide/how-to/* $(INSTDOCDIR)/userguide/how-to
>>  	install -m 644 doc/userguide/reference/* $(INSTDOCDIR)/userguide/reference
>> +	install -m 755 examples/*.d $(INSTDOCDIR)/examples
>> +	install -m 644 examples/README.md $(INSTDOCDIR)/examples
>> +	install -m 755 examples/language_features/* $(INSTDOCDIR)/examples/language_features
> ... you want the files to be executable? I suppose they're .d scripts
> starting with a hashbang, so that makes sense.
>

Yeah, they are like that in the dtrace/examples directory, so I just maintained that.

elena