[PATCH v2] Guard against inserting the same provider twice
[email protected] Fri, 16 Jan 2026 15:38:12 -0500
| Newsgroups | dev.linux.lists.dtrace |
|---|---|
| Message-ID | <[email protected]> |
From: Eugene Loh <[email protected]> Add a safety net to dt_provider_create(), to check if a specified provider has already been inserted. This also requires a corresponding change in dt_provider_lookup(), so that it will work even if no providers have yet been inserted. Signed-off-by: Eugene Loh <[email protected]> --- libdtrace/dt_provider.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libdtrace/dt_provider.c b/libdtrace/dt_provider.c index 848fdc132..e073e1f2d 100644 --- a/libdtrace/dt_provider.c +++ b/libdtrace/dt_provider.c @@ -1,6 +1,6 @@ /* * Oracle Linux DTrace. - * Copyright (c) 2006, 2025, Oracle and/or its affiliates. All rights reserved. + * Copyright (c) 2006, 2026, Oracle and/or its affiliates. All rights reserved. * Licensed under the Universal Permissive License v 1.0 as shown at * http://oss.oracle.com/licenses/upl. */ @@ -110,6 +110,9 @@ dt_provider_lookup(dtrace_hdl_t *dtp, const char *name) { dt_provider_t tmpl; + if (dtp->dt_provs == NULL) + return NULL; + if ((strlen(name) + 1) > sizeof(tmpl.desc.dtvd_name)) return NULL; @@ -124,6 +127,10 @@ dt_provider_create(dtrace_hdl_t *dtp, const char *name, { dt_provider_t *pvp; + pvp = dt_provider_lookup(dtp, name); + if (pvp) + return pvp; + if ((pvp = dt_zalloc(dtp, sizeof(dt_provider_t))) == NULL) goto nomem; -- 2.47.3