Re: [PATCH] test: Add ERROR clause to prevent hang from runtime error

On Fri, Jan 16, 2026 at 09:57:59PM -0500, [email protected] wrote:
> From: Eugene Loh <[email protected]>
> 
> These tests XFAIL.  Since they incur runtime failures, the scripts hang,
> waiting for the test suite to time them out.
> 
> Add an ERROR clause to each test, so that XFAILs do not hang needlessly.
> 
> Signed-off-by: Eugene Loh <[email protected]>

Reviewed-by: Kris Van Hees <[email protected]>

> ---
>  test/unittest/funcs/strtok/tst.strtok.d | 8 +++++++-
>  test/unittest/funcs/substr/tst.substr.d | 8 +++++++-
>  test/unittest/types/tst.struct.d        | 8 +++++++-
>  test/unittest/types/tst.typedef.d       | 8 +++++++-
>  4 files changed, 28 insertions(+), 4 deletions(-)
> 
> diff --git a/test/unittest/funcs/strtok/tst.strtok.d b/test/unittest/funcs/strtok/tst.strtok.d
> index 8ffe1066..b39e44bc 100644
> --- a/test/unittest/funcs/strtok/tst.strtok.d
> +++ b/test/unittest/funcs/strtok/tst.strtok.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2026, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -124,3 +124,9 @@ tick-1ms
>  {
>  	exit(0);
>  }
> +
> +ERROR
> +{
> +	printf("ERROR\n");
> +	exit(1);
> +}
> diff --git a/test/unittest/funcs/substr/tst.substr.d b/test/unittest/funcs/substr/tst.substr.d
> index 4dcef73b..580dfa0f 100644
> --- a/test/unittest/funcs/substr/tst.substr.d
> +++ b/test/unittest/funcs/substr/tst.substr.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2008, 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2008, 2026, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -209,3 +209,9 @@ tick-1ms
>  	printf("\texit($failed);\n}\n");
>  	exit(0);
>  }
> +
> +ERROR
> +{
> +	printf("ERROR\n");
> +	exit(1);
> +}
> diff --git a/test/unittest/types/tst.struct.d b/test/unittest/types/tst.struct.d
> index 627a8585..77499789 100644
> --- a/test/unittest/types/tst.struct.d
> +++ b/test/unittest/types/tst.struct.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2026, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -49,3 +49,9 @@ BEGIN
>  
>  	exit(0);
>  }
> +
> +ERROR
> +{
> +	printf("ERROR\n");
> +	exit(1);
> +}
> diff --git a/test/unittest/types/tst.typedef.d b/test/unittest/types/tst.typedef.d
> index 744c93c2..7ec3bcd3 100644
> --- a/test/unittest/types/tst.typedef.d
> +++ b/test/unittest/types/tst.typedef.d
> @@ -1,6 +1,6 @@
>  /*
>   * Oracle Linux DTrace.
> - * Copyright (c) 2006, 2020, Oracle and/or its affiliates. All rights reserved.
> + * Copyright (c) 2006, 2026, Oracle and/or its affiliates. All rights reserved.
>   * Licensed under the Universal Permissive License v 1.0 as shown at
>   * http://oss.oracle.com/licenses/upl.
>   */
> @@ -49,3 +49,9 @@ BEGIN
>  
>  	exit(0);
>  }
> +
> +ERROR
> +{
> +	printf("ERROR\n");
> +	exit(1);
> +}
> -- 
> 2.47.3
>