Re: [DTrace-devel] [PATCH] configure: add support for --disable-option-checking
Kris Van Hees <[email protected]> Wed, 18 Feb 2026 00:07:32 -0500
| Newsgroups | dev.linux.lists.dtrace |
|---|---|
| Message-ID | <[email protected]> |
On Tue, Feb 17, 2026 at 04:03:38PM -0500, Eugene Loh wrote: > Looks fine except again this should probably be documented when "--help" is > used. Sure. > Also, I don't know if you agree on moving those enable-dependency options. > If so, I guess this patch won't apply cleanly? I think it is better not to move them. > On 2/17/26 12:01, Kris Van Hees via DTrace-devel wrote: > > > Signed-off-by: Kris Van Hees <[email protected]> > > --- > > configure | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/configure b/configure > > index fadac05e..f10c7f4d 100755 > > --- a/configure > > +++ b/configure > > @@ -123,6 +123,11 @@ rm -rf build/.config.new build/.config-vars.mk.new > > echo 'override CONFIGURED_VARS=' > build/.config-vars.mk.new > > trap 'rm -rf build/.config.new build/.config-vars.mk.new' ERR > > +# Should we report unknown --disable/enable/with/without-* options? > > +if echo " $@ " | grep ' --disable-option-checking ' &>/dev/null; then > > + no_check_opts=t > > +fi > > + > > for option in "$@"; do > > case "$option" in > > --help) help; exit 1;; > > @@ -174,6 +179,11 @@ for option in "$@"; do > > HAVE_BPFMASM=*) write_config_var BPFMASM "$option";; > > --disable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "y";; > > --enable-dependency-tracking) write_make_var WITHOUT_DEPENDENCIES "n";; > > + --disable-*|--enable-*|--with-*|--without-*) > > + if [[ -z $no_check_opts ]]; then > > + echo "Unknown option $option" >&2 > > + exit 1 > > + fi;; > > *) echo "Unknown option $option" >&2 > > exit 1;; > > esac