Re: [DTrace-devel] [PATCH v2] Fix flowindent for "return" probes with multiple statements

On 30 Mar 2026, eugene loh spake thusly:

> From: Eugene Loh <[email protected]>
>
> The flowindent algorithm should change indentation based only on the
> number of levels of entry and return.  So, if an entry or return probe
> has multiple statements, the indentation should change only for the
> first statement.
>
> Such logic is used for entry probes.  Similar logic should be used for
> return probes.
>
> Add a test to cover the case of multiple statements per entry and return
> probes.  Also have it check a greater number of indentations.  Since
> the new test supersedes the old ones, remove the old tests, which
> were fickle anyhow.  The new test can still fail -- the flowindent
> algorithm is not completely robust -- so allow reinvocation in case of
> failure.  The intermittent failures of flowindent tests have long been a
> testing irritant.  Now, with reinvocation, testing shows no failures in
> 100 iterations on over a dozen systems.
>
> Orabug: 39140395
> Signed-off-by: Eugene Loh <[email protected]>

Reviewed-by: Nick Alcock <[email protected]>

Much better tests!

-- 
NULL && (void)