Re: [PATCH 5/6] fbt: retrieve function return value using helper
Nick Alcock <[email protected]> Tue, 28 Apr 2026 21:52:04 +0100
| Newsgroups | dev.linux.lists.dtrace |
|---|---|
| Message-ID | <[email protected]> |
On 28 Apr 2026, Kris Van Hees outgrape: > We were causing BPF verifier errors when trying to access the return value > of some functions due to incorrect calculation of the offset to read from. > Rather than implementing the more complex logic needed to calculate the > proper offset of the return value, we can just use the bpf_get_func_ret() > BPF helper. This does not impose a performance decrease because that > helper gets inlined by the BPF verifier. Presumably we are a suitable probe type? ... yes, we are. > Signed-off-by: Kris Van Hees <[email protected]> Reviewed-by: Nick Alcock <[email protected]> Looks much nicer. -- NULL && (void)