Re: [PATCH]run unit tests on both OpenSSL-1.x and OpenSSL-3.x
wen zhang <zhw2101024 at gmail.com>
| Newsgroups | dev.linux.lists.ell |
|---|---|
| Message-ID | <CAKjfnjogWuHB1MmUqQOnVjiXvjHR-cPk_TMjgsjduQ=6JGVUbQ@mail.gmail.com> |
Mat Martineau <mathew.j.martineau(a)linux.intel.com> 于2022年4月7日周四 06:15写道： > > On Tue, 29 Mar 2022, wen zhang wrote: > > > Some unit tests are breaking on systems with OpenSSL 3.x. > > This patch detects the OpenSSL version, then if we are building Ell on > > OpenSSL 3.x, the legacy module options will be appended to openssl > commands. > > Hi Wen Zhang - > > I noticed that ELL is not building the unit tests on the Fedora 36 beta > due to this OpenSSL 3 command line issue with the legacy providers. > > Unfortunately, your patch didn't work on Fedora 36. I see these lines > added to the Makefile generated with the bootstrap-configure script: > > OPENSSL_LEGACY_OPTS = > OPENSSL_LIBDIR = > > In addition, the openssl legacy provider options are not included in the > openssl commands. > > > Also, be sure to send patches using 'git send-email' so they do not use > HTML or attachments. More patch submission guidelines are here: > https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/HACKING > > > Thanks, > > -- > Mat Martineau > Intel > Thanks for the feedback! And sorry for the noise. I'm building ELL on one system built following LFS project. Maybe it's different on Fedora 36. I'll use git send-email next time.
attachment.htm
(text/html, 1.7 KB)
<div dir="ltr"><div dir="ltr">Mat Martineau <<a href="mailto:[email protected]">[email protected]</a>> 于2022年4月7日周四 06:15写道：<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br> On Tue, 29 Mar 2022, wen zhang wrote:<br> <br> > Some unit tests are breaking on systems with OpenSSL 3.x.<br> > This patch detects the OpenSSL version, then if we are building Ell on<br> > OpenSSL 3.x, the legacy module options will be appended to openssl commands.<br> <br> Hi Wen Zhang -<br> <br> I noticed that ELL is not building the unit tests on the Fedora 36 beta <br> due to this OpenSSL 3 command line issue with the legacy providers.<br> <br> Unfortunately, your patch didn't work on Fedora 36. I see these lines <br> added to the Makefile generated with the bootstrap-configure script:<br> <br> OPENSSL_LEGACY_OPTS =<br> OPENSSL_LIBDIR =<br> <br> In addition, the openssl legacy provider options are not included in the <br> openssl commands.<br> <br> <br> Also, be sure to send patches using 'git send-email' so they do not use <br> HTML or attachments. More patch submission guidelines are here: <br> <a href="https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/HACKING" rel="noreferrer" target="_blank">https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/HACKING</a><br> <br> <br> Thanks,<br> <br> --<br> Mat Martineau<br> Intel<br></blockquote><div><div>Thanks for the feedback! And sorry for the noise.<br></div><div>I'm building ELL on one system built following LFS project. Maybe it's different on Fedora 36.</div><div>I'll use git send-email next time.<br></div> </div></div></div>