Re: [PATCH 01/11] net: Add l_net_subnet_matches
Andrew Zaborowski <andrew.zaborowski at intel.com>
| Newsgroups | dev.linux.lists.ell |
|---|---|
| Message-ID | <CAOq732LP7Gsfsgoq463zMSpJKiiG3BNu7V1nm+Upx=WW1yrbfQ@mail.gmail.com> |
Hi Denis, On Thu, 21 Apr 2022 at 04:37, Denis Kenzior <denkenz(a)gmail.com> wrote: > > I put the following comment in one of the patches: > > > > + * TODO: check if we have a prefix route covering the IP, > > + * l_dhcp6_client doesn't guarantee that the received IP is in > > + * on of the subnets marked as on-link in the RA. > > > > You keep repeating this, but I still don't believe this is true. You could have > RA gateway address being link-local, or subnet C. The prefix info in the RA > could be subnet B and the DHCPv6 address obtained could be in subnet A with no > overlap. Why would you want to? Who knows ;) However complicated the setup is, you have access to all the routes on the interface so it's not a problem. But the point really is that whoever implements a check like this, and other possible scenarios, if they choose to use ell they might end up with an out of bounds access. Best regards