Re: [PATCH] dhcp: Use bound_time for retransmission timers

Sorry, I put the log for the t2 retry. Putting it in the right place
gives us our problem though

```
May 13 15:38:34 r2-19006 iwd[39610]: [DHCPv4] dhcp_client_t1_expired:630
May 13 15:38:34 r2-19006 iwd[39610]: [DHCPv4]
dhcp_client_t1_expired:632 Entering state: DHCP_STATE_RENEWING
May 13 15:38:34 r2-19006 iwd[39610]: [DHCPv4] dhcp_client_send_request:397
May 13 15:38:34 r2-19006 iwd[39610]: [DHCPv4]
dhcp_client_t1_expired:642 next_timeout t2: 225
May 13 15:38:34 r2-19006 iwd[39610]: [DHCPv4]
dhcp_client_t1_expired:651 next_timeout t1 retry: 896458022
```

Regards,
Michael

On Fri, 13 May 2022 at 16:31, Michael Johnson <mjohnson459(a)gmail.com> wrote:
>
> Hi Denis,
>
> I added those log lines and got this.
>
> ```
> May 13 15:20:14 r2-19006 iwd[28716]: [DHCPv4]
> dhcp_client_rx_message:949 T1 expiring in 299004 ms
> May 13 15:20:14 r2-19006 iwd[28716]: [DHCPv4] l_acd_start:455 Skipping
> probes and sending announcements
> May 13 15:20:14 r2-19006 iwd[28716]: [DHCPv4]
> announce_wait_timeout:166 No conflicts found for 10.101.8.24,
> announcing address
> May 13 15:20:14 r2-19006 iwd[28716]: [DHCPv4] acd_send_packet:146
> sending packet with target IP 10.101.8.24
> May 13 15:25:13 r2-19006 iwd[28716]: [DHCPv4] dhcp_client_t1_expired:630
> May 13 15:25:13 r2-19006 iwd[28716]: [DHCPv4]
> dhcp_client_t1_expired:632 Entering state: DHCP_STATE_RENEWING
> May 13 15:25:13 r2-19006 iwd[28716]: [DHCPv4] dhcp_client_send_request:397
> May 13 15:25:13 r2-19006 iwd[28716]: [DHCPv4]
> dhcp_client_t1_expired:643 next_timeout: 225
> May 13 15:28:58 r2-19006 iwd[28716]: [DHCPv4] dhcp_client_t2_expired:609
> May 13 15:28:58 r2-19006 iwd[28716]: [DHCPv4]
> dhcp_client_t2_expired:616 Entering state: DHCP_STATE_REBINDING
> May 13 15:30:12 r2-19006 iwd[28716]: [DHCPv4] dhcp_client_lease_expired:598
> ```
>
> Regards,
> Michael
>
> On Fri, 13 May 2022 at 15:30, Denis Kenzior <denkenz(a)gmail.com> wrote:
> >
> > Hi Michael,
> >
> > On 5/13/22 08:53, Michael Johnson wrote:
> > > Hi Denis,
> > >
> > > I've been running this patch for the day and I don't think it's
> > > actually fixed the retry. I have set a low lease time and then block
> > > the DHCP server for the ACK and I can see that the retry still doesn't
> > > happen.
> >
> > I suspect it does fix one bug, but not another...  I'm not near my test box
> > right now, so debugging this is a bit painful.
> >
> > Could you debug-print the 'next_timeout' we calculate in
> > dhcp_client_t1_expired() here:
> >
> >          next_timeout = dhcp_rebind_renew_retry_time(client->start_t,
> >                                                          client->lease->t2);
> >
> > And also put in
> >          L_WARN_ON(!client->timeout_resend);
> >
> > after the timeout_resend timer is created?
> >
> >  From your 'other' bug report yesterday, we calculate the t1 timer correctly,
> > but the timer still doesn't fire.
> > It almost feels like the timers are just not being created.  Is there anything
> > suspicious in the kernel logs?
> >
> > Regards,
> > -Denis