Re: [PATCH 3/4] icmp6: Respect lifetime values in a RA

On Mon, 3 Jan 2022 at 20:01, Denis Kenzior <denkenz(a)gmail.com> wrote:
> On 1/3/22 08:18, Andrew Zaborowski wrote:
> > "A value of zero indicates that the router is not to be used as a
> > default router."
> >
>
> You may want to put this into the code directly.

Ok, for some reason we don't quote the RFC in this file.

>
> > Also set the lifetime values on the routes to those received so that the
> > user of, say, l_icmp6_client_get_router(), can also determine whether
> > there is a default router.
>
> Note that we do not re-upload the routes to the kernel on every RA received.
> See the TODO comment in icmp6_client_handle_message().  Once lifetime expires,
> the route will be removed -> internet is broke.  Please at least sanity test the
> changes you're sending out or label them as RFC if you haven't done so.

Ok, I've dropped the l_icmp6_client_set_rtnl() use locally in IWD so
this wouldn't have shown up even if the router had set a short
lifetime.  But I need some way for the user to check if there's a
default gateway.

Best regards