[PATCH 1/3] tls: Use l_put_be64 for IV creation in case of AEAD ciphers
Marcel Holtmann <[email protected]> Tue, 3 Jan 2023 15:39:58 +0100
| Newsgroups | dev.linux.lists.ell |
|---|---|
| Message-ID | <[email protected]> |
The usage of l_put_le64 for encryption ciphers seems weird since normally all its input is big endian. So change this here to also use big endian version to store the sequence number. --- ell/tls-record.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ell/tls-record.c b/ell/tls-record.c index cdbd0b8040bb..6ac095629abe 100644 --- a/ell/tls-record.c +++ b/ell/tls-record.c @@ -177,7 +177,7 @@ static void tls_tx_record_plaintext(struct l_tls *tls, * be used to build the IV. */ memcpy(iv, tls->fixed_iv[1], tls->fixed_iv_length[1]); - l_put_le64(tls->seq_num[1], iv + tls->fixed_iv_length[1]); + l_put_be64(tls->seq_num[1], iv + tls->fixed_iv_length[1]); if (tls->record_iv_length[1] > 8) memset(iv + tls->fixed_iv_length[1] + 8, 42, -- 2.39.0