Re: ELL 0.59 Does Not Compile against Linux-4.9.212 and/or GLibC-2.28
Marcel Holtmann <[email protected]> Tue, 21 Nov 2023 19:50:11 +0100
| Newsgroups | dev.linux.lists.ell |
|---|---|
| Message-ID | <[email protected]> |
Hi Grant,
>>>>> Over on the connman mailing list, Marcel and Denis have been advocating, rightly so, for iwd over wpa_supplicant for Wi-Fi.
>>>>> Is there a kernel version expectation of ELL?
>>>
>>> Will do. I’m running openssl-1.1.1w.
>>>
>>> Regarding the patches, won’t inclusion of an uprev netlink header result in a -ENOSYS or -EINVAL when those symbols hit the downrev kernel? Or were they privately defined in the 4.x series but not publicly exported?
>>
>> any chance you can give ell-0.60 a spin and let me know if this helps. The only thing we left out was the RTA_EXPIRES workaround and I need to think about this a bit harder on how to work around it.
>
> Thank you for investing time on this. Here are my latest results against linux-4.9.212, glibc-2.37, and the Arm GNU Toolchain 12.3.1 against ell-0.60:
<snip>
>
> CC ell/dbus.lo
> ${BuildRoot}/third_party/ell/ell-0.60/ell/netlink.c: In function 'netlink_parse_ext_ack_error':
> ${BuildRoot}/third_party/ell/ell-0.60/ell/netlink.c:649:36: error: 'NLM_F_ACK_TLVS' undeclared (first use in this function); did you mean 'NLM_F_ACK'?
> 649 | if (!(nlmsg->nlmsg_flags & NLM_F_ACK_TLVS))
> | ^~~~~~~~~~~~~~
> | NLM_F_ACK
> ${BuildRoot}/third_party/ell/ell-0.60/ell/netlink.c:649:36: note: each undeclared identifier is reported only once for each function it appears in
> ${BuildRoot}/third_party/ell/ell-0.60/ell/netlink.c:657:36: error: 'NLM_F_CAPPED' undeclared (first use in this function); did you mean 'NLM_F_APPEND'?
> 657 | if (!(nlmsg->nlmsg_flags & NLM_F_CAPPED))
> | ^~~~~~~~~~~~
> | NLM_F_APPEND
> make[2]: *** [Makefile:2026: ell/netlink.lo] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [Makefile:1296: all] Error 2
> make[1]: Leaving directory '${BuildRoot}/third_party/ell/.build/Makefile/${PRODUCT}/arm/gnu-toolchain/12.3.1/release'
> make: *** [Makefile:94: build] Error 2
this seems rather simple to fix and just an oversight on my part. Patch to fix this is on the mailing list. Hopefully that is enough.
Regards
Marcel