Re: [PATCH 2/2] unit: add testing for dbus-over-tcp

On 5/13/24 12:58 PM, Ram Subramanian wrote:
> Co-authored-by: Ramon Ribeiro <[email protected]>

Since the unit test was all yours, I removed this line.

> ---
>   unit/dbus.conf   |   2 +
>   unit/test-dbus.c | 118 +++++++++++++++++++++++++++++++++--------------
>   2 files changed, 85 insertions(+), 35 deletions(-)
> 

<snip>

> @@ -135,18 +154,19 @@ static void request_name_callback(struct l_dbus_message *message,
>   	const char *error, *text;
>   	uint32_t result;
>   
> +	req_name_cb_called = true;
> +
>   	if (l_dbus_message_get_error(message, &error, &text)) {
>   		l_error("error=%s", error);
>   		l_error("message=%s", text);
> -		goto done;
> +		test_assert(false);
>   	}
>   
> -	if (!l_dbus_message_get_arguments(message, "u", &result))
> -		goto done;
> +	test_assert(l_dbus_message_get_arguments(message, "u", &result));
>   
>   	l_info("request name result=%d", result);
>   
> -done:
> +	tests_completed ++;

I moved this to test_dbus() and fixed up the style (no spaces before ++).

Applied, thanks.

Regards,
-Denis