Re: missing header files

Hi Andreas,

On 8/26/24 7:38 AM, Andreas Radke wrote:
> Using "make install" target seems to not install some of the header
> files. I've run into missing ell/useful.h for recent iwd build from git
> master.

ell/useful.h and ell/asn1-private.h are special.  They're copied from the ell 
tree when iwd is built.  Even if using shared ell, you need to setup ell as 
described in the README

> 
> Can you clarify whether all these header files should be installed when
> building a distribution package and please make the Makefile install
> those that are expected to be present on the system.
> 

These files are included in the distribution package.
[denkenz@archdev iwd]$ tar -Jtvf iwd-2.19.tar.xz | grep useful
-rw-r--r-- denkenz/denkenz   1979 2024-08-16 10:31 iwd-2.19/ell/useful.h
[denkenz@archdev iwd]$ tar -Jtvf iwd-2.19.tar.xz | grep asn1
-rw-r--r-- denkenz/denkenz   4406 2024-08-16 10:31 iwd-2.19/ell/asn1-private.h

> cp ell/*.h "$pkgdir"/usr/include/ell/ shows these additional files now:
> 
> /usr/include/ell/asn1-private.h
> /usr/include/ell/cert-private.h
> /usr/include/ell/dbus-private.h
> /usr/include/ell/dhcp-private.h
> /usr/include/ell/dhcp6-private.h
> /usr/include/ell/ecc-private.h
> /usr/include/ell/gvariant-private.h
> /usr/include/ell/icmp6-private.h
> /usr/include/ell/main-private.h
> /usr/include/ell/missing.h
> /usr/include/ell/net-private.h
> /usr/include/ell/netlink-private.h
> /usr/include/ell/pem-private.h
> /usr/include/ell/private.h
> /usr/include/ell/rtnl-private.h
> /usr/include/ell/siphash-private.h
> /usr/include/ell/time-private.h
> /usr/include/ell/tls-private.h
>   usr/include/ell/useful.h

None of these files are to be installed by ell, they're not part of the public API.

Regards,
-Denis