Re: [PATCH v9 0/9] Input/Output Terminal Abstraction

Hi Grant,

> This expands on Marcel Holtman's 2023-12-22 RFCv4 patch for an
> input/output terminal abstraction.
>=20
> Substantive changes from the v7 version:
>=20
>  * Fixed a typo in the  ASCII C0 and C1 control code mnemonics.
>=20
> Grant Erickson (9):
>  term: Initial revision.

I actually reverted it back to my version and included printf / vprintf =
helpers.

What is the purpose of l_term_set_bounds? Is it important for non-TTY =
setups since for TTY compatible terminals, this should not be needed.

The  l_term_io_callback and l_term_process is something I don=E2=80=99t =
really like since I rather keep that internal.

>  ell: Add include directive for 'ell/term.h'.
>  ell/Makefile: Added 'term.[ch]' to HEADERS and SOURCES.
>  term: Added 'l_term_*' symbols.

These 3 were already in my latest set.

>  ell/term: Do not return -EPERM for 'putnstr' and 'vprint' if not
>    running.

Why is that important. It seems like a hack. If you haven=E2=80=99t =
successfully acquired the terminal, there is no point in writing to it =
since you have no idea what termios setting are dealing with.

>  ell/term: Return error on writes if the output descriptor is invalid.

Seems like a fix for the previous change.

>  ell/edit: Rename 'l_term_{open,close}'.

I incorporated that into my set. Makes sense to me.

>  ell/term: Add an 'l_term_is_acquired' introspection function.

I added it, but don=E2=80=99t really know how it would be used.

>  ell/term: Added ASCII C0 and C1 control code mnemonics.

Hmm. We could do that, but the constant name is too long for my taste. =
And why use an enum instead of defines?

Regards

Marcel