Re: [PATCH 1/4] dbus-filter: avoid NULL pointer dereference after removing all rules

Denis Kenzior <[email protected]> Fri, 27 Jun 2025 16:42:39 -0500
Newsgroups dev.linux.lists.ell
Message-ID <[email protected]>
Hi Christian,

On 6/25/25 8:14 AM, Christian Eggers wrote:
> l_dbus_register() is called by _dbus_filter_new() directly before the
> first filter rule is added (so filter->root is only transitional NULL).
> Later, if all filter rules have been removed, filter->root is
> permanently NULL which causes NULL pointer dereference in
> _dbus_filter_dispatch() / filter_dispatch_match_recurse().
> 
> I get this situation after creating a D-Bus proxy and destroying the
> proxy later (so that no filter rules are left, but the D-Bus' filter is
> still registered).
> ---
>   ell/dbus-filter.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 

All applied.  Thanks for these!

Regards,
-Denis