[PATCH 4/5] unit: Respect TAP comments format

Bastien Nocera <[email protected]> Thu, 31 Jul 2025 16:20:38 +0200
Newsgroups dev.linux.lists.ell
Message-ID <[email protected]>
Comment lines must start with '#'.
---
 unit/test-cipher.c |  8 ++++----
 unit/test-key.c    | 10 +++++-----
 unit/test-pem.c    | 10 +++++-----
 unit/test-tls.c    | 12 ++++++------
 4 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/unit/test-cipher.c b/unit/test-cipher.c
index 23bc748f7f4e..1abe9cff593f 100644
--- a/unit/test-cipher.c
+++ b/unit/test-cipher.c
@@ -543,10 +543,10 @@ static void test_aead(const void *data)
 	success = l_aead_cipher_encrypt(cipher, pt, ptlen, aad, aadlen,
 					nonce, noncelen, encbuf, encbuflen);
 	if (!success) {
-		printf("* Some kernel versions before v4.9 have a known AEAD\n"
-			"* bug. If the system running this test is using a\n"
-			"* v4.8 or earlier kernel, a failure here is likely\n"
-			"* due to that kernel bug.\n");
+		printf("# Some kernel versions before v4.9 have a known AEAD\n"
+			"# bug. If the system running this test is using a\n"
+			"# v4.8 or earlier kernel, a failure here is likely\n"
+			"# due to that kernel bug.\n");
 	}
 	assert(success);
 
diff --git a/unit/test-key.c b/unit/test-key.c
index cd5c28a2e5db..c9eb8507da81 100644
--- a/unit/test-key.c
+++ b/unit/test-key.c
@@ -555,11 +555,11 @@ static void test_key_crypto(const void *data)
 	privkey = l_pem_load_private_key(CERTDIR "cert-client-key-pkcs8.pem",
 						NULL, NULL);
 	if (!privkey) {
-		l_info("* Some kernel versions do not automatically load\n"
-			"* the pkcs8_key_parser module. If the system running\n"
-			"* test has not loaded this module, a failure here is\n"
-			"* likely. Running \"modprobe pkcs8_key_parser\" may\n"
-			"* correct this issue.\n");
+		l_info("# Some kernel versions do not automatically load\n"
+			"# the pkcs8_key_parser module. If the system running\n"
+			"# test has not loaded this module, a failure here is\n"
+			"# likely. Running \"modprobe pkcs8_key_parser\" may\n"
+			"# correct this issue.\n");
 		exit(1);
 	}
 
diff --git a/unit/test-pem.c b/unit/test-pem.c
index 7580b6ae59c3..7ee0597ed172 100644
--- a/unit/test-pem.c
+++ b/unit/test-pem.c
@@ -202,11 +202,11 @@ static void test_priv_key_from_data(const void *data)
 						strlen(raw_private_key),
 						"abc", &is_encrypted);
 	if (!key) {
-		l_info("* Some kernel versions do not automatically load\n"
-			"* the pkcs8_key_parser module. If the system running\n"
-			"* test has not loaded this module, a failure here is\n"
-			"* likely. Running \"modprobe pkcs8_key_parser\" may\n"
-			"* correct this issue.\n");
+		l_info("# Some kernel versions do not automatically load\n"
+			"# the pkcs8_key_parser module. If the system running\n"
+			"# test has not loaded this module, a failure here is\n"
+			"# likely. Running \"modprobe pkcs8_key_parser\" may\n"
+			"# correct this issue.\n");
 		exit(1);
 	}
 
diff --git a/unit/test-tls.c b/unit/test-tls.c
index a95de3b314f4..540416974751 100644
--- a/unit/test-tls.c
+++ b/unit/test-tls.c
@@ -613,12 +613,12 @@ static void test_tls_with_ver(const struct tls_conn_test *test,
 						test->server_key_passphrase,
 						NULL);
 		if (!server_key) {
-			l_info("* Some kernel versions do not automatically\n"
-				"* load the pkcs8_key_parser module. If the\n"
-				"* system running test has not loaded this\n"
-				"* module, a failure here is likely. Running\n"
-				"* \"modprobe pkcs8_key_parser\" may correct\n"
-				"* this issue.\n");
+			l_info("# Some kernel versions do not automatically\n"
+				"# load the pkcs8_key_parser module. If the\n"
+				"# system running test has not loaded this\n"
+				"# module, a failure here is likely. Running\n"
+				"# \"modprobe pkcs8_key_parser\" may correct\n"
+				"# this issue.\n");
 			exit(1);
 		}
 
-- 
2.50.0