Re: [PATCH] test: only flag parse tests as little-endian-only in test-gvariant-message

Hi Amaan,

> The blanket `l_test_set_default_flags(L_TEST_FLAG_LITTLE_ENDIAN_ONLY)`
> marks all gvariant-message tests as little-endian-only, but the build
> and rewind tests work correctly on big-endian. This causes an XPASS
> (unexpected pass) on big-endian systems, which autotools treats as a
> test suite failure.
>=20
> This commit applies the flag only to the three parse tests that =
compare
> against hardcoded little-endian byte sequences.
> ---
> unit/test-gvariant-message.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)


this does not work.

  CC       unit/test-gvariant-message.o
  CCLD     unit/test-gvariant-message
SKIP: unit/test-gvariant-message 1 - Basic 1 (parse) # SKIP =
little-endian-only
FAIL: unit/test-gvariant-message 2 - Basic 1 (build)
SKIP: unit/test-gvariant-message 3 - Complex 1 (parse) # SKIP =
little-endian-only
PASS: unit/test-gvariant-message 4 - Complex 1 (build)
SKIP: unit/test-gvariant-message 5 - Empty signature (parse) # SKIP =
little-endian-only
PASS: unit/test-gvariant-message 6 - Empty signature (build)
PASS: unit/test-gvariant-message 7 - Message Builder Rewind Complex 1

Regards

Marcel