Re: [PATCH v2 2/2] treewide: run internal library tests in "make check"

On 8/21/26 16:02, Namjae Jeon wrote:
>> diff --git a/configure.ac b/configure.ac
>> index ab6fb5d..99bad24 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -52,7 +52,7 @@ PKG_CHECK_MODULES([BLKID], [blkid >= 2.20], [AC_DEFINE([HAVE_BLKID], [1], [Defin
>>         [PKG_CHECK_MODULES([EXT2_BLKID], [blkid], [AC_DEFINE([HAVE_EXT2_BLKID], [1], [Define if libblkid is from libext2])])])
>>
>>  AC_ARG_ENABLE([tests],
>> -       AS_HELP_STRING([--enable-tests], [build internal test programs])
>> +       AS_HELP_STRING([--enable-tests], [always build internal test programs (not just for "make check")]),
>>         [enable_tests=yes]
> I have updated it like this and will apply it to #exfat-next.
>
> -       AS_HELP_STRING([--enable-tests], [build internal test programs])
> +       AS_HELP_STRING([--enable-tests], [always build internal test
> programs (not just for "make check")]),
> -       [enable_tests=yes]
> +       [enable_tests=$enableval],
> +       [enable_tests=no]
>
> Thanks!
Just a quick question: is this a real problem where "enable_tests" is
set to "yes" before running ./configure? I don't object to explicitly
specifying [enable_tests=no] as a common pattern going forward. I'm just
curious if there's any reasoning behind this.

Davo