Re: [Fuego] Procedure to commit the code

Kumar Thangavel <[email protected]>
Newsgroups dev.linux.lists.fuego
Message-ID <SG2PR04MB3029F295AE2F4278A0273CB1FD6B0@SG2PR04MB3029.apcprd04.prod.outlook.com> 
Thanks a lot for your information Tim.


  As we discussed earlier, I have added one Functional test cases "Functional.check_mounts". This is the initial version of the code. This will compare the expected mount points of boards with actual board mounted points. If any expected mount points is not mounted in the board, test will fail.

Please find the attached patch file. Could you please review this and provide your valuable comments on this.

Thanks,
Kumar.
________________________________
From: [email protected] <[email protected]>
Sent: 23 October 2019 02:18
To: Kumar Thangavel <[email protected]>; [email protected] <[email protected]>
Subject: RE: [Fuego] Procedure to commit the code



> -----Original Message-----
> From: Kumar Thangavel
>
> Hi All,
>
>          I am new to fuego framework. I have developed one test cases for
> fuego framework. So I want to commit the initial version of the code.  Could
> you please tell the procedure to commit the code.

There are two ways to submit code for Fuego mainline.

The preferred method for a new submitter is to format the change as a patch,
and send it to the mailing list.  Please create a commit in your own fuego-core
repository, and then do 'git format-patch' to create a patch (or a series of patches)
for it.

See this wiki page for some details about preferred format:
https://apc01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ffuegotest.org%2Fwiki%2FLicense_And_Contribution_Policy%23Submitting_contributions&amp;data=02%7C01%7Cthangavel.k%40hcl.com%7C7d3a459ea9ee43ea62fe08d757312ee9%7C189de737c93a4f5a8b686f4ca9941912%7C0%7C0%7C637073741088090245&amp;sdata=Q2yvUv0pxvUgNEYjp5EJ3%2BgD4uHbopUGQWZI8Qizp%2Bg%3D&amp;reserved=0

(And see the first part of the page for license considerations.)


> ::DISCLAIMER::
>
> ________________________________
>
> The contents of this e-mail and any attachment(s) are confidential and
> intended for the named recipient(s) only. E-mail transmission is not
> guaranteed to be secure or error-free as information could be intercepted,
> corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses
> in transmission. The e mail and its contents (with or without referred errors)
> shall therefore not attach any liability on the originator or HCL or its affiliates.
> Views or opinions, if any, presented in this email are solely those of the
> author and may not necessarily reflect the views or opinions of HCL or its
> affiliates. Any form of reproduction, dissemination, copying, disclosure,
> modification, distribution and / or publication of this message without the
> prior written consent of authorized representative of HCL is strictly
> prohibited. If you have received this email in error please delete it and notify
> the sender immediately. Before opening any email and/or attachments,
> please check them for viruses and other defects.
> ________________________________

If you can, please figure out a way to remove this DISCLAIMER from your messages.
Sending a "confidential" email to an open mailing list is a contradiction.  I can
deal with the contradiction for non-code e-mails, as the submission to the list
essentially negates the prohibition on disclosure and dissemination.  However, for
code this will come in conflict with the license, and it creates enough ambiguity
that it's a problem accepting patches with the clause attached.

I know that many businesses tack such clauses onto outbound e-mail automatically,
so it might be something you have no control over.  If so, you may have to submit
the patch from an e-mail account outside your business (such as a gmail account),
to avoid having this disclaimer attached.
 -- Tim
1301-This-PATCH-added-test-cases-to-check-the-expected-mo.patch (text/x-patch, 5.6 KB) 
From 6e8012276d86d418b190ef37290bf23f785248fd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=8B?= <​>
Date: Wed, 23 Oct 2019 16:14:17 +0530
Subject: [PATCH 1301/1301] This PATCH added test cases to check the expected
 mount points with system mount points, if any mount point is not matched test
 will fail. This is the Initial version of code with default spec.
 Signed-off-by: Kumar Thangavel <[email protected]>

---
 tests/Functional.check_mounts/fs-test-1.1.tgz | Bin 0 -> 2209 bytes
 tests/Functional.check_mounts/fuego_test.sh   |  19 ++++++++++++++++++
 tests/Functional.check_mounts/spec.json       |   7 +++++++
 tests/Functional.check_mounts/test.yaml       |  15 ++++++++++++++
 4 files changed, 41 insertions(+)
 create mode 100644 tests/Functional.check_mounts/fs-test-1.1.tgz
 create mode 100755 tests/Functional.check_mounts/fuego_test.sh
 create mode 100644 tests/Functional.check_mounts/spec.json
 create mode 100644 tests/Functional.check_mounts/test.yaml

diff --git a/tests/Functional.check_mounts/fs-test-1.1.tgz b/tests/Functional.check_mounts/fs-test-1.1.tgz
new file mode 100644
index 0000000000000000000000000000000000000000..1f832d3c62f4b21b36c1148313c20841fae9ecdb
GIT binary patch
literal 2209
zcmV;S2wwLeiwFQZDX?7t1MOLRbJ|D}_rK^<bP?YgdwKemDmzX^1`(^4hf9cLbB>D=
zVg%X<jY^N$j?dqHyGIfd7$?~~@1|16RASJ~^snFDqrnO)Aq&DvquQu#{Y|5e<K@v2
zeKuYm)$^a}*lHXc9Ua#94-XD;zR{>3?{C4;-z89fL_uiy09(v+zPj&Q>p$tRa{jl1
z5q+<k&&=cN{%`Czj*nOTzyGp+yan}VmSgSsKlgua@B4-Xd$5QPsDR1mp5fc>6v7#U
z;4TQ+94y;OzXxz*hck!*<^#L+m>IIk(mDbXW|Mn&zCE3VuwQQ+!+^VYIOluZH$t1c
zv_+1>8TU`%w`h)@(r1P{H9j*3UWMt`>Zdm|)2X6NuZf^zo6HT^33OFGVROm+xg7+E
z2zCH7=Ckn~Ont*evC3fii~+a6oEiR<l_BI{pd23a10>+%(6C)pm4FP?+`FUA;S7-i
zZiP37&v5?)j3D5qZIGrDZbozFhC&IUcK{`{6hRaR2~lxZu$nN#0oxUZOqYc9coc$<
z2KQ}~V9L13bfQTjNxH+a=XSz}5QH%U!bRJcg|uau^NDTIClmU4(b%zrS(#uaHZd4S
zA<hRhFKkyPg=*Y~fH@9<*r<R|I+IcCK}Lk)k$uC&VuJh4jL(-<LUUP>?;>M15qfhp
zpJ4h2hDQQK6c%?JenYWka(7~rYQah3NFCRWG5^ejW^v@WJVdEuX~-#F=ImrCm>H<X
zSeQRHB8q?}H*(7PBncJ+H?+|o7=VKBs?ya|jtd0_{kHyI))Y_&aH;j*sV$`iMR|bF
z#WK8C^^5*c2i&2_J^cgp+aUKoz;9}=B`mM}eyJ&g0rWLcyO$kRX_Z0kH9NzW+ItJ<
zNZRY`&`~jp5m)aEo(Y<&AYGeKx{B7kz!~{m?Wp>PGPG5_N3d<gmEls>bhSC`$QoP@
zwaflMK_Oa1*z5PyURy(6N>}OWRpgCxpuEEe7+lDmj$kMcQ4LK<+3a6_(A2jVI$ZQS
zEkzp;%(;Rh%I6&=W{3(lJF?m>Lrd<;Zxun<M<7jXOJsb1p@=DDDfdK<H+8k&BNH|I
zJzc}cGHR^p3+ngkKq-T)sRJ@jTk9hSvMy4P{R9Y-_LLZijKAz7+(pmBfs#qoQsfT8
z4M+~0AdGZB`T6@sO_E+DF$J%JaANc7?Df(VmC4n)iDQqK=R$kVXhy1Gbg?;AK>sc-
znV2j=$o;f-?gW_7k&EfZZ5MMLMR+k`mhCchen;uaT?LA@aPHNJx+oCaOE`;){1gtx
zCR$Qyjk^6|PahF16jQ2^pbDztZ5V?qOK<@gzHi(?V1Hq2F)@Tk1NGkumi)g!E+olQ
zAH~$?k!4|%S?DG}5UibVMu<bjJzcbdt5vw`t4H!(p9%)=u+JG|1jB+V3YRI2MpYr@
zm1}Io3atqlt5LlF4C;s{ygL)6&=pl3>o^u6pBa-!h-p{#dD2=D`ZKpDVt4F>i4hv5
zUFlvb2=(?HwA5%ESrCsi=nXraQ>j4498s@`mq)_5LZU*DUla3!kd{afJ4EB=N32Id
zgv6fZ(Rb9T@3FZ52(x2p6&hjR5mFZ{59ut9n@VYjmZ9hucN22u7Q2TyF<6G}L=@`S
z(;_@Y%n%o;(PE^E0JE(U;l;}BN~vJ?Qcg<j0Y3LjMTI^Pg`^_(>4_x{d@`RfZS|u|
zvg805N>oyQS26fywKLQdTrNDs(!OP}`z_lKV#B3vLST`QDNJV7GnlfF9!tNZZYaYq
zOCG_Kh({JliIG)@a}SYy9!>Eyg}upv8*FuGpb2;5W5RmIvC5^4|7&#I8e<hQUaD*Q
zj7}}UBR^Iv4qY;OvTY@*fBlslnAa6`xmqx-G_KEfKGt_~n`-fyZ^;kK@s3f)VH{_5
zjx*L#)4MBW8BCFRU0!e{|0G*!MM#$CnmWy8w~5bk;Qx)A(r9SY>5-7}G{H@A{1fn*
z3aQcQoLS1ryA&jpwQ0Tz+@`|=mgUrh1*UI%SmTx;P1;ow0zG`Yyeu8XAJrE;K~WEk
z&-S_CdZNr_wJ4z&rSLzrHl+`=!*Y!2;~oD)^;**ye{3OJY2}-W_M8<>gijJOE4jM1
z$ieccWx4by`O-WR`aY3h3o$SNDAv#Fry}NGt;l?uRJ`2<#r@)&$ONlI)pPEZGC!@<
z(On9|oHcU;u@+z+o@GM|qjBjdD1z<`uKpEVLw9AOm{sV<Ofdipg%tB+s4D{<@SSMb
z(UJO69t`3j#!ZPQ8d*da3S-RDPp7eT4-17K*119O5Kf5Pxe=PPr;SZXDVVLZM{J8#
zE5IWwV3y;nCps>2#fxUP0bjhs;&Ru@A+FkhGBvTmLcJA{e%c<FbC0=bb=G&cI&$dT
zu-&-Dh|<f<C`^xbn0Rw>DTDtp0~7eA_Z?ai?+lal`XxPOrz}O|N|3IuQS@RA@E<U4
zKEcj?99H7qz%Ok#%7FhI=1#*IKJD&4?7(ZtUc_RZbD{=<X)0+VLolN&7xG&io26tu
z?J(N9R|UxT^1LR6)pv!{!V1jVs<ezl(k&ed7OaDe$5+k(f~U{I$akrhK1e_M)^jt`
zk-z`%8lM>X`?-01>-V3d<oBP0`oZzx@k_e@KRP(v-2eX*1MB%oda*A_?-XsI_Iqa-
z4U#Tvbh<rDBV_wNS$(L6(=U=lWs09<KMF{N?fYi)0k&U3g~Rq6NirQ~xF?wTbEsGu
z6Z(s@Z>s4JPEheBiSD6e0uUc5S+!c*zE5O%pr^<3#Ka3a$AwBj{KUQ|NDAcj$_y&z
zm(QzADovb#N`>8utGTniT6JoNd+->h_S09geEw^S-0CXT`Q({-eDn9;Mq@Sq4{&*t
j|Np>vkp#d`AIO`r8Jn>go3R<2@!jK3Lgh0d04M+e6E#B`

literal 0
HcmV?d00001

diff --git a/tests/Functional.check_mounts/fuego_test.sh b/tests/Functional.check_mounts/fuego_test.sh
new file mode 100755
index 0000000..7e93f6f
--- /dev/null
+++ b/tests/Functional.check_mounts/fuego_test.sh
@@ -0,0 +1,19 @@
+tarball=fs-test-1.1.tgz
+
+function test_build {
+    make
+}
+
+function test_deploy {
+    put fs_test $BOARD_TESTDIR/fuego.$TESTDIR/
+    put /fuego-rw/boards/rpi3/expected_mounts.txt $BOARD_TESTDIR/fuego.$TESTDIR/
+}
+ 
+function test_run {
+    report "cd $BOARD_TESTDIR/fuego.$TESTDIR; \
+        ./fs_test"
+}
+
+function test_processing {
+    log_compare "$TESTDIR" "0" "FAIL" "n"
+}
diff --git a/tests/Functional.check_mounts/spec.json b/tests/Functional.check_mounts/spec.json
new file mode 100644
index 0000000..65eab4d
--- /dev/null
+++ b/tests/Functional.check_mounts/spec.json
@@ -0,0 +1,7 @@
+{
+    "testName": "Functional.check_mounts",
+    "specs": {
+        "default": {}
+    }
+}
+
diff --git a/tests/Functional.check_mounts/test.yaml b/tests/Functional.check_mounts/test.yaml
new file mode 100644
index 0000000..57942b5
--- /dev/null
+++ b/tests/Functional.check_mounts/test.yaml
@@ -0,0 +1,15 @@
+fuego_package_version: 1
+name: Functional.check_mounts
+description: |
+    Sample test that runs fs_test. This test
+    comes with specs to check the expected mounts with system's mount.
+license: MIT
+author: Kumar Thangavel <[email protected]>
+maintainer: Kumar Thangavel <[email protected]>
+version: 1.1
+fuego_release: 1
+type: Functional
+tags: ['example']
+data_files:
+ - fs-test-1.1.tgz
+ - spec.json
-- 
2.17.1
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.