Re: [Fuego] Procedure to commit the code

> -----Original Message-----
> From: Kumar Thangavel
> 
> Hi Tim,
> 
> Apologies for the disclaimer part. I am not aware about disclaimer.
> I will register with gmail account and send patch from gmail account.
It's odd.  I don't get the disclaimer on every message from you.
So I don't know when it is applied and when it is not by your mail
transfer agents.

When you sent your patch as an attachment, there was no new
disclaimer attached (but maybe your mail transfer agent was smart
enough to notice the disclaimer already embedded in the quoted
part of the message.

> 
> Otherwise,
> Could you please let me know if there is a git repo for clone, update and
> commit my code changes.
> So that i can submit my code changes for the review instead of sending
> patches to email.

Having now reviewed your commit, I'm not sure if you are talking about
the repository for fs_test (as a separate tool referenced by Functional.check_mounts)
or the repository for fuego-core, so that you can submit a pull request via
bitbucket rather than via e-mail.

The repository address of fuego-core (where tests live) is:
https://bitbucket.org/fuegotest/fuego-core

If you create a clone of this repository on bitbucket you can easily submit
pull requests.  However, my normal mode of working with external repositories
is to add them as remotes to my local repository and cherry-pick the patches
individually.

Having said all that, I strongly prefer to review patches via e-mail.  Some MTAs
(mail transfer agents) mangle patches making them so they can't be applied.
That's why I support sending the patch as an attachment (which MTAs won't
mangle).  However, it's still handy to see the patch in plain text in the body 
of the message.  If you have an MTA that mangles patches, please send
the patch in both the body of the email (for review) and as an attachment
(for application to my repository).  This is a bit redundant, but transmitting
the patch via e-mail allows for everyone (not just me) to review and comment
on the patch, which is sometimes very helpful.
 -- Tim