Re: [Fuego] Procedure to commit the code

Thank you, Tim, for your comments.

Please find the answers inline below

This subject should have had the format:
[PATCH 1/1]
      Sure. I will modify the subject line as like above

I'm not sure how you generated the patch, but for the top-most commit
      I used git format-patch command to create a patch. I will use git format-patch HEAD^ to create patch.

I will modify the code as per your comments and will attach the patch in the mail along with all source files.


Thanks,
Kumar.







________________________________
From: [email protected] <[email protected]>
Sent: 04 November 2019 15:30
To: Kumar Thangavel <[email protected]>; [email protected] <[email protected]>
Subject: RE: [Fuego] Procedure to commit the code



> -----Original Message-----
> From: Kumar Thangavel
>
> Hi Tim,
>
> Apologies for the disclaimer part. I am not aware about disclaimer.
> I will register with gmail account and send patch from gmail account.
It's odd.  I don't get the disclaimer on every message from you.
So I don't know when it is applied and when it is not by your mail
transfer agents.

When you sent your patch as an attachment, there was no new
disclaimer attached (but maybe your mail transfer agent was smart
enough to notice the disclaimer already embedded in the quoted
part of the message.

>
> Otherwise,
> Could you please let me know if there is a git repo for clone, update and
> commit my code changes.
> So that i can submit my code changes for the review instead of sending
> patches to email.

Having now reviewed your commit, I'm not sure if you are talking about
the repository for fs_test (as a separate tool referenced by Functional.check_mounts)
or the repository for fuego-core, so that you can submit a pull request via
bitbucket rather than via e-mail.

The repository address of fuego-core (where tests live) is:
https://apc01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbitbucket.org%2Ffuegotest%2Ffuego-core&amp;data=02%7C01%7Cthangavel.k%40hcl.com%7C0bee43bf855947a6692008d7610dd18c%7C189de737c93a4f5a8b686f4ca9941912%7C0%7C0%7C637084584315837125&amp;sdata=Wyhe4b610%2FiHCaWYqC6x%2FziuWOEU3pfdJ%2B%2FBQHbm%2FBo%3D&amp;reserved=0

If you create a clone of this repository on bitbucket you can easily submit
pull requests.  However, my normal mode of working with external repositories
is to add them as remotes to my local repository and cherry-pick the patches
individually.

Having said all that, I strongly prefer to review patches via e-mail.  Some MTAs
(mail transfer agents) mangle patches making them so they can't be applied.
That's why I support sending the patch as an attachment (which MTAs won't
mangle).  However, it's still handy to see the patch in plain text in the body
of the message.  If you have an MTA that mangles patches, please send
the patch in both the body of the email (for review) and as an attachment
(for application to my repository).  This is a bit redundant, but transmitting
the patch via e-mail allows for everyone (not just me) to review and comment
on the patch, which is sometimes very helpful.
 -- Tim

::DISCLAIMER::
________________________________
The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects.
________________________________