Re: [Fuego] Patch for Functional.check_mounts

Kumar T <[email protected]>
Newsgroups dev.linux.lists.fuego
Message-ID <CA+wOOGi2+wQ6mHJiT+DpWLYt5ODbxTHUHKH_kcPOnkZ9K2k5TA@mail.gmail.com> 
Hi Tim,

Thanks for your comments.

I have combined the patches as single patch. Please find the attached PATCH
and source files.

Thanks,
Kumar.

On Wed, 20 Nov 2019 at 01:10, <[email protected]> wrote:

>
>
> > -----Original Message-----
> > From: Kumar T
> >
> > Hi Tim,
> >
> >       I am Kumar from HCL Technologies. I am developing test cases for
> > "Functional.check_mounts" as discussed earlier. Updated the code as per
> > your review comments.
> >
> >
> > Please find the attached PATCH and other source files. Please review.
>
> The patch you sent consists of edits on top of material that is not
> upstream
> yet.
>
> You need to combine this work with the previous work and submit it
> as one patch.  If the previous patch had been accepted upstream,
> this patch consisting of changes would be appropriate.  However,
> I need to see the entire test as a single patch in order to review it.
>
> Please use an interactive rebase to combine the commits into a single
> commit, and then send that patch.  You can see this blog entry:
>
> https://thoughtbot.com/blog/git-interactive-rebase-squash-amend-rewriting-history
> for some instructions on how to do a rebase.  See especially the section
> "Squash commits together".
>
> Thanks,
>  -- Tim
>
>
>
>
>
>
0001-check_mounts-PATCH-1-1.patch (text/x-patch, 6.2 KB) 
From e743b49fe70950a8bd3e799808f531b72d4b9ff0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E2=80=8B?= <​>
Date: Wed, 23 Oct 2019 16:14:17 +0530
Subject: [PATCH] <check_mounts>:[PATCH 1/1]

This PATCH added test cases to check the expected mounts
with system mount points. If any mount point is not matched
test would fail. It has save_baseline spec to save the
system mount points as expected mount points.

Signed-off-by: Kumar Thangavel <[email protected]>
---
 tests/Functional.check_mounts/fs-test-1.1.tgz | Bin 0 -> 2209 bytes
 tests/Functional.check_mounts/fuego_test.sh   |  41 ++++++++++++++++++
 tests/Functional.check_mounts/spec.json       |  11 +++++
 tests/Functional.check_mounts/test.yaml       |  15 +++++++
 4 files changed, 67 insertions(+)
 create mode 100644 tests/Functional.check_mounts/fs-test-1.1.tgz
 create mode 100755 tests/Functional.check_mounts/fuego_test.sh
 create mode 100644 tests/Functional.check_mounts/spec.json
 create mode 100644 tests/Functional.check_mounts/test.yaml

diff --git a/tests/Functional.check_mounts/fs-test-1.1.tgz b/tests/Functional.check_mounts/fs-test-1.1.tgz
new file mode 100644
index 0000000000000000000000000000000000000000..1f832d3c62f4b21b36c1148313c20841fae9ecdb
GIT binary patch
literal 2209
zcmV;S2wwLeiwFQZDX?7t1MOLRbJ|D}_rK^<bP?YgdwKemDmzX^1`(^4hf9cLbB>D=
zVg%X<jY^N$j?dqHyGIfd7$?~~@1|16RASJ~^snFDqrnO)Aq&DvquQu#{Y|5e<K@v2
zeKuYm)$^a}*lHXc9Ua#94-XD;zR{>3?{C4;-z89fL_uiy09(v+zPj&Q>p$tRa{jl1
z5q+<k&&=cN{%`Czj*nOTzyGp+yan}VmSgSsKlgua@B4-Xd$5QPsDR1mp5fc>6v7#U
z;4TQ+94y;OzXxz*hck!*<^#L+m>IIk(mDbXW|Mn&zCE3VuwQQ+!+^VYIOluZH$t1c
zv_+1>8TU`%w`h)@(r1P{H9j*3UWMt`>Zdm|)2X6NuZf^zo6HT^33OFGVROm+xg7+E
z2zCH7=Ckn~Ont*evC3fii~+a6oEiR<l_BI{pd23a10>+%(6C)pm4FP?+`FUA;S7-i
zZiP37&v5?)j3D5qZIGrDZbozFhC&IUcK{`{6hRaR2~lxZu$nN#0oxUZOqYc9coc$<
z2KQ}~V9L13bfQTjNxH+a=XSz}5QH%U!bRJcg|uau^NDTIClmU4(b%zrS(#uaHZd4S
zA<hRhFKkyPg=*Y~fH@9<*r<R|I+IcCK}Lk)k$uC&VuJh4jL(-<LUUP>?;>M15qfhp
zpJ4h2hDQQK6c%?JenYWka(7~rYQah3NFCRWG5^ejW^v@WJVdEuX~-#F=ImrCm>H<X
zSeQRHB8q?}H*(7PBncJ+H?+|o7=VKBs?ya|jtd0_{kHyI))Y_&aH;j*sV$`iMR|bF
z#WK8C^^5*c2i&2_J^cgp+aUKoz;9}=B`mM}eyJ&g0rWLcyO$kRX_Z0kH9NzW+ItJ<
zNZRY`&`~jp5m)aEo(Y<&AYGeKx{B7kz!~{m?Wp>PGPG5_N3d<gmEls>bhSC`$QoP@
zwaflMK_Oa1*z5PyURy(6N>}OWRpgCxpuEEe7+lDmj$kMcQ4LK<+3a6_(A2jVI$ZQS
zEkzp;%(;Rh%I6&=W{3(lJF?m>Lrd<;Zxun<M<7jXOJsb1p@=DDDfdK<H+8k&BNH|I
zJzc}cGHR^p3+ngkKq-T)sRJ@jTk9hSvMy4P{R9Y-_LLZijKAz7+(pmBfs#qoQsfT8
z4M+~0AdGZB`T6@sO_E+DF$J%JaANc7?Df(VmC4n)iDQqK=R$kVXhy1Gbg?;AK>sc-
znV2j=$o;f-?gW_7k&EfZZ5MMLMR+k`mhCchen;uaT?LA@aPHNJx+oCaOE`;){1gtx
zCR$Qyjk^6|PahF16jQ2^pbDztZ5V?qOK<@gzHi(?V1Hq2F)@Tk1NGkumi)g!E+olQ
zAH~$?k!4|%S?DG}5UibVMu<bjJzcbdt5vw`t4H!(p9%)=u+JG|1jB+V3YRI2MpYr@
zm1}Io3atqlt5LlF4C;s{ygL)6&=pl3>o^u6pBa-!h-p{#dD2=D`ZKpDVt4F>i4hv5
zUFlvb2=(?HwA5%ESrCsi=nXraQ>j4498s@`mq)_5LZU*DUla3!kd{afJ4EB=N32Id
zgv6fZ(Rb9T@3FZ52(x2p6&hjR5mFZ{59ut9n@VYjmZ9hucN22u7Q2TyF<6G}L=@`S
z(;_@Y%n%o;(PE^E0JE(U;l;}BN~vJ?Qcg<j0Y3LjMTI^Pg`^_(>4_x{d@`RfZS|u|
zvg805N>oyQS26fywKLQdTrNDs(!OP}`z_lKV#B3vLST`QDNJV7GnlfF9!tNZZYaYq
zOCG_Kh({JliIG)@a}SYy9!>Eyg}upv8*FuGpb2;5W5RmIvC5^4|7&#I8e<hQUaD*Q
zj7}}UBR^Iv4qY;OvTY@*fBlslnAa6`xmqx-G_KEfKGt_~n`-fyZ^;kK@s3f)VH{_5
zjx*L#)4MBW8BCFRU0!e{|0G*!MM#$CnmWy8w~5bk;Qx)A(r9SY>5-7}G{H@A{1fn*
z3aQcQoLS1ryA&jpwQ0Tz+@`|=mgUrh1*UI%SmTx;P1;ow0zG`Yyeu8XAJrE;K~WEk
z&-S_CdZNr_wJ4z&rSLzrHl+`=!*Y!2;~oD)^;**ye{3OJY2}-W_M8<>gijJOE4jM1
z$ieccWx4by`O-WR`aY3h3o$SNDAv#Fry}NGt;l?uRJ`2<#r@)&$ONlI)pPEZGC!@<
z(On9|oHcU;u@+z+o@GM|qjBjdD1z<`uKpEVLw9AOm{sV<Ofdipg%tB+s4D{<@SSMb
z(UJO69t`3j#!ZPQ8d*da3S-RDPp7eT4-17K*119O5Kf5Pxe=PPr;SZXDVVLZM{J8#
zE5IWwV3y;nCps>2#fxUP0bjhs;&Ru@A+FkhGBvTmLcJA{e%c<FbC0=bb=G&cI&$dT
zu-&-Dh|<f<C`^xbn0Rw>DTDtp0~7eA_Z?ai?+lal`XxPOrz}O|N|3IuQS@RA@E<U4
zKEcj?99H7qz%Ok#%7FhI=1#*IKJD&4?7(ZtUc_RZbD{=<X)0+VLolN&7xG&io26tu
z?J(N9R|UxT^1LR6)pv!{!V1jVs<ezl(k&ed7OaDe$5+k(f~U{I$akrhK1e_M)^jt`
zk-z`%8lM>X`?-01>-V3d<oBP0`oZzx@k_e@KRP(v-2eX*1MB%oda*A_?-XsI_Iqa-
z4U#Tvbh<rDBV_wNS$(L6(=U=lWs09<KMF{N?fYi)0k&U3g~Rq6NirQ~xF?wTbEsGu
z6Z(s@Z>s4JPEheBiSD6e0uUc5S+!c*zE5O%pr^<3#Ka3a$AwBj{KUQ|NDAcj$_y&z
zm(QzADovb#N`>8utGTniT6JoNd+->h_S09geEw^S-0CXT`Q({-eDn9;Mq@Sq4{&*t
j|Np>vkp#d`AIO`r8Jn>go3R<2@!jK3Lgh0d04M+e6E#B`

literal 0
HcmV?d00001

diff --git a/tests/Functional.check_mounts/fuego_test.sh b/tests/Functional.check_mounts/fuego_test.sh
new file mode 100755
index 0000000..609999b
--- /dev/null
+++ b/tests/Functional.check_mounts/fuego_test.sh
@@ -0,0 +1,41 @@
+tarball=fs-test-1.1.tgz
+
+function test_build {
+    make
+}
+
+function test_deploy {
+
+    EXPECTED_FILE=/fuego-rw/boards/$NODE_NAME/expected_mounts.txt
+
+    if [ "$TESTSPEC" = "default" ] ; then
+
+    	if [ -f "${EXPECTED_FILE}" ] ; then
+      	    put "${EXPECTED_FILE}" $BOARD_TESTDIR/fuego.$TESTDIR/ 
+	else
+            abort_job "Please create file ${EXPECTED_FILE} with the list of expected mounts"
+        fi
+
+        put fs_test $BOARD_TESTDIR/fuego.$TESTDIR/
+    fi
+
+}
+ 
+function test_run {
+
+    DATA_FILE=$LOGDIR/expected_mount_data.txt
+
+    if [ "$TESTSPEC" = "save_baseline" ] ; then
+        mount | awk '{print substr($1, 1, length($1))}'>$DATA_FILE
+	cp $DATA_FILE ${EXPECTED_FILE}
+        log_this "echo \"baseline file: ${EXPECTED_FILE} saved\""
+        return 0
+    else
+        report "cd $BOARD_TESTDIR/fuego.$TESTDIR; \
+        ./fs_test"
+    fi
+}
+
+function test_processing {
+    log_compare "$TESTDIR" "0" "FAIL" "n"
+}
diff --git a/tests/Functional.check_mounts/spec.json b/tests/Functional.check_mounts/spec.json
new file mode 100644
index 0000000..e3e383f
--- /dev/null
+++ b/tests/Functional.check_mounts/spec.json
@@ -0,0 +1,11 @@
+{
+    "testName": "Functional.check_mounts",
+    "specs": {
+        "default": {
+	},
+	"save_baseline": {
+            "save_baseline": "true"
+	}
+    }
+}
+
diff --git a/tests/Functional.check_mounts/test.yaml b/tests/Functional.check_mounts/test.yaml
new file mode 100644
index 0000000..beaa67c
--- /dev/null
+++ b/tests/Functional.check_mounts/test.yaml
@@ -0,0 +1,15 @@
+fuego_package_version: 1
+name: Functional.check_mounts
+description: |
+    Run fs_test, using an 'expected_mounts.txt' file, in order to verify
+    that the mouned filesystems on the target board are as expected.
+license: MIT
+author: Kumar Thangavel <[email protected]>
+maintainer: Kumar Thangavel <[email protected]>
+version: 1.1
+fuego_release: 1
+type: Functional
+tags: ['example']
+data_files:
+ - fs-test-1.1.tgz
+ - spec.json
-- 
2.17.1
fs-test-1.1.tgz (application/x-compressed-tar, 2.2 KB) - not displayed
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.