Re: [Fuego] [PATCH 02/12] skip cases missing ftp cmd

> -----Original Message-----
> From:  qiutt
> 
> for m3ulcb, skip cases in  network_commands and net.tcp_cmds
> 
> Signed-off-by: qiutt <[email protected]>
> ---
>  tests/Functional.LTP/fuego_test.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tests/Functional.LTP/fuego_test.sh b/tests/Functional.LTP/fuego_test.sh
> index 7f1a97f..8aaffd8 100755
> --- a/tests/Functional.LTP/fuego_test.sh
> +++ b/tests/Functional.LTP/fuego_test.sh
> @@ -235,6 +235,10 @@ function test_pre_check {
>      skip_if_command_unavailable touch "ext4-nsec-timestamps"
>      skip_if_command_unavailable quotacheck "quotactl01"
> 
> +    # some cmds do not exist in m3ulcb

In general, this type of comment is not needed in the code,
if there is sufficient explanation in the commit message.

However, this one is innocuous enough that I'm going to leave it.

> +    skip_if_command_unavailable ftp "ftp04" # for network_commands
> +    skip_if_command_unavailable ftp "ftp" # for net.tcp_cmds
> +
>      echo "Tests skipped depending on the configuration of the target kernel"
>      skip_if_kconfig_differs "CONFIG_INOTIFY_USER=y" "inotify_init1_01 inotify_init1_02 inotify01 inotify02 inotify03 inotify04 inotify05
> inotify06"
>      skip_if_kconfig_differs "CONFIG_FANOTIFY=y CONFIG_FANOTIFY_ACCESS_PERMISSIONS=y" "fanotify01 fanotify02 fanotify03
> fanotify04 fanotify05 fanotify06"
> --
> 2.11.0

This looks reasonable.  I'm applying it to the 'master' branch.
 -- Tim