Re: [Fuego] [PATCH 1/2] fuego-host-scripts: Have docker executable and libltdl7 in container

Hi

> -----Original Message-----
> From: Fuego <[email protected]> On Behalf Of Bird, Tim
> Sent: Thursday, July 16, 2020 5:38 AM
> To: Laszlo Sitzer <[email protected]>; [email protected]
> Subject: Re: [Fuego] [PATCH 1/2] fuego-host-scripts: Have docker executable and libltdl7 in container
> 
> 
> 
> > -----Original Message-----
> > From:  Laszlo Sitzer
> >
> > This is one step towards fixing Functional.fuego_release_test which is
> > currently broken.
> >
> > In order to start fixing it, I made /usr/bin/docker available in the
> > container by bind-mounting it. To be able to execute the docker
> > command-line client libltdl7 had to be installed into the container.
> >
> > Signed-off-by: Laszlo Sitzer <[email protected]>
> > ---
> >  Dockerfile                                    | 5 +++++
> >  fuego-host-scripts/docker-create-container.sh | 1 +
> >  2 files changed, 6 insertions(+)
> >
> > diff --git a/Dockerfile b/Dockerfile
> > index f42b6c7..e6b7af4 100644
> > --- a/Dockerfile
> > +++ b/Dockerfile
> > @@ -69,6 +69,11 @@ RUN apt-get -q=2 -V --no-install-recommends install \
> >      netpipe-tcp iputils-ping
> >  RUN pip install flake8
> >
> > +# Fuego release test dependencies
> > +# - libltdl7 - needed for /usr/bin/docker RUN apt-get -q=2 -V
> > +--no-install-recommends install \
> > +        libltdl7
> > +
> >  # miscelaneous packages:
> >  # python-serial - used by serio
> >  # diffstat and vim - used by Tim
> > diff --git a/fuego-host-scripts/docker-create-container.sh
> > b/fuego-host-scripts/docker-create-container.sh
> > index c122cd9..d7844e6 100755
> > --- a/fuego-host-scripts/docker-create-container.sh
> > +++ b/fuego-host-scripts/docker-create-container.sh
> > @@ -24,6 +24,7 @@ fi
> >
> >  sudo docker create -it --name ${DOCKERCONTAINER} \
> >      -v /var/run/docker.sock:/var/run/docker.sock \
> > +    -v /usr/bin/docker:/usr/bin/docker \
> >      -v /boot:/boot:ro \
> >      -v $DIR/../fuego-rw:/fuego-rw \
> >      -v $DIR/../fuego-ro:/fuego-ro:ro \

Related to the volume vs bind mount discussion. Since Docker 17.06 there is such distinction, so technically instead of -v we should be using --mount. However, Docker has kept back compatibility.
https://docs.docker.com/storage/bind-mounts/

Daniel


> > --
> > 2.27.0
> 
> I think this is not needed because docker is installed locally in the container in Dockerfile.test.  I believe you said to ignore your changes
> related to Dockerfile, after you found Dockerfile.test.  So I'm dropping this patch.
> Let me know if that's not right.
>  -- Tim
> 
> _______________________________________________
> Fuego mailing list
> [email protected]
> https://lists.linuxfoundation.org/mailman/listinfo/fuego