Re: [Fuego] [PATCH 09/12] skip cases because label rule does not support

Hi,Tim

For patch08, use CONFIG configuration item as skip check condition.
See patch: 0008-skip-cases-because-MULTIPORT-and-LIMIT-not-set.patch

For patch09, "smack_file_access" failed because of the label rule setting problem in the system environment of the board, which has nothing to do with the case and architecture. 
The original skip condition is not suitable. 
Do you have any better suggestions to skip this case?

Thanks,
 -- QiuTingting

-----Original Message-----
From: Bird, Tim [mailto:[email protected]] 
Sent: Thursday, July 9, 2020 6:23 AM
To: Qiu, Tingting/仇 婷婷 <[email protected]>; [email protected]
Subject: RE: [Fuego] [PATCH 09/12] skip cases because label rule does not support



> -----Original Message-----
> From: qiutt
> 
> for m3ulcb, skip cases in smack
> 
> Signed-off-by: qiutt <[email protected]>
> ---
>  tests/Functional.LTP/fuego_test.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/Functional.LTP/fuego_test.sh 
> b/tests/Functional.LTP/fuego_test.sh
> index 9963678..2ac7caf 100755
> --- a/tests/Functional.LTP/fuego_test.sh
> +++ b/tests/Functional.LTP/fuego_test.sh
> @@ -356,6 +356,7 @@ function test_pre_check {
>      if [ "$ARCHITECTURE" == "aarch64" ]; then
>          skip_tests "netstat" # for net.tcp_cmds, 'netstat -s' not support
>          skip_tests "iptables" # for net.tcp_cmds  
> CONFIG_NETFILTER_XT_MATCH_MULTIPORT is not set, 
> CONFIG_NETFILTER_XT_MATCH_LIMIT is not set
> +        skip_tests "smack_file_access" # for smack, label rule does 
> + not support

You can't use ARCHITECTURE == aarch64 as a proxy for testing for specific features of m3ulcb (particularly smack - which is completely independent of architecture and board).

>      fi
>  }
> 
> --
> 2.11.0
Not accepted.  Find another way to avoid running this.  Maybe based on a kernel config variable?
 -- Tim

From 6eae7eeaccd7c3287f4e70fc96a259f5a8d16c3d Mon Sep 17 00:00:00 2001
From: qiutt <[email protected]>
Date: Thu, 30 Jul 2020 14:17:39 +0800
Subject: [PATCH 2/2] skip cases because MULTIPORT and LIMIT not set

for m3ulcb, skip cases in net.tcp_cmds
if the following configs not set:
 CONFIG_NETFILTER_XT_MATCH_MULTIPORT=y
 CONFIG_NETFILTER_XT_MATCH_LIMIT=y

Signed-off-by: qiutt <[email protected]>
---
 tests/Functional.LTP/fuego_test.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/Functional.LTP/fuego_test.sh b/tests/Functional.LTP/fuego_test.sh
index 88dea7e..d5cbeaa 100755
--- a/tests/Functional.LTP/fuego_test.sh
+++ b/tests/Functional.LTP/fuego_test.sh
@@ -265,6 +265,7 @@ function test_pre_check {
     skip_if_kconfig_differs "CONFIG_CHECKPOINT_RESTORE=y" "kcmp01 kcmp02 kcmp03"
     skip_if_kconfig_differs "CONFIG_SWAP=y" "swapoff01 swapoff02 swapon01 swapon02 swapon03"
     skip_if_kconfig_differs "CONFIG_SGETMASK_SYSCALL=y" "ssetmask01"
+    skip_if_kconfig_differs "CONFIG_NETFILTER_XT_MATCH_MULTIPORT=y CONFIG_NETFILTER_XT_MATCH_LIMIT=y" "iptables" # for net.tcp_cmds
 
     echo "Tests skipped depending on the config skiplist file"
     skip_tests_with_config_skiplist "CONFIG_XFRM_USER=y" "CONFIG_XFRM_USER_skiplist.txt"
-- 
2.11.0