Re: [Fuego] [PATCH] IOzone: remove single quotation

Hi Tim,

I've pulled all new stuffs regarding IOzone and tested them.
The changes work fine in my customised testing environment!

Thank you for reviewing and I also appreciate your additional effort.

P.S. I should have sent the patch as an attachment... I'll do so next time.

Regards,
Fukui

> -----Original Message-----
> From: [email protected] [mailto:[email protected]]
> Sent: Wednesday, June 23, 2021 7:35 AM
> To: fukui daichi(福意 大智 □ＳＷＣ◯ＡＣＴ) <[email protected]>;
> [email protected]
> Subject: RE: [PATCH] IOzone: remove single quotation
> 
> Daichi-san,
> 
> The patch looks good.  I applied it and pushed it to the master branch.
> 
> When testing the patch (and running IOZone on several different platforms),
> and found some other bugs.  I decided to fix those, and update the version
> of IOzone that Fuego uses for testing.
> 
> I upgraded to version 492 (from version 353), which resolve an issue with
> a missing build setting (HAVE_PREAD) for the x86_64 architecture
> (the iozone target 'linux-AMD64'). I also added a chart_type to the
> chart_config.json file, and added a test.yaml file for the test as well.
> 
> All these changes have been pushed to the current master branch
> of fuego-core.  Can you please pull that branch, and run the Benchmark.IOzone
> test to make sure that nothing has broken for your usage of the test?
> 
> Thanks very much for the patch.  It was good to get this test fixed up
> and cleaned up!
>  -- Tim
> 
> 
> > -----Original Message-----
> > From: Fuego <[email protected]> On Behalf Of
> [email protected]
> >
> > From 48bac4939a46eac4a5d31856a734c14fa19ef0fe Mon Sep 17 00:00:00 2001
> >
> > From: Daichi Fukui <[email protected]>
> >
> > Date: Mon, 21 Jun 2021 18:54:19 +0900
> >
> > Subject: [PATCH] IOzone: remove single quotation
> >
> >
> >
> > With single quotations in TESTS variables, the specified
> >
> > tests (-i) are not passed correctly to the iozone command,
> >
> > ending up with testing only write/re-writes in giving
> >
> > a prepared specification defined in specs.json.
> >
> > Thus we should remove the single quotations so that
> >
> > we can correctly pass our specified tests.
> >
> >
> >
> > Signed-off-by: Daichi Fukui <[email protected]>
> >
> > ---
> >
> > tests/Benchmark.IOzone/spec.json | 10 +++++-----
> >
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> >
> >
> > diff --git a/tests/Benchmark.IOzone/spec.json
> b/tests/Benchmark.IOzone/spec.json
> >
> > index 05af9b8..e1fbc3b 100644
> >
> > --- a/tests/Benchmark.IOzone/spec.json
> >
> > +++ b/tests/Benchmark.IOzone/spec.json
> >
> > @@ -6,31 +6,31 @@
> >
> >              "MOUNT_BLOCKDEV":"$SATA_DEV",
> >
> >              "MOUNT_POINT":"$SATA_MP",
> >
> >              "FILE_SIZE":"2M",
> >
> > -            "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
> >
> > +            "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
> >
> >          },
> >
> >          "mmc": {
> >
> >              "MOUNT_BLOCKDEV":"$MMC_DEV",
> >
> >              "MOUNT_POINT":"$MMC_MP",
> >
> >              "FILE_SIZE":"2M",
> >
> > -            "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
> >
> > +            "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
> >
> >          },
> >
> >          "usb": {
> >
> >              "MOUNT_BLOCKDEV":"$USB_DEV",
> >
> >              "MOUNT_POINT":"$USB_MP",
> >
> >              "FILE_SIZE":"2M",
> >
> > -            "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
> >
> > +            "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
> >
> >          },
> >
> >          "nopread": {
> >
> >              "MOUNT_BLOCKDEV":"ROOT",
> >
> >              "MOUNT_POINT":"$BOARD_TESTDIR/work",
> >
> >              "FILE_SIZE":"2M",
> >
> > -            "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8'"
> >
> > +            "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8"
> >
> >          },
> >
> >          "default": {
> >
> >              "MOUNT_BLOCKDEV":"ROOT",
> >
> >              "MOUNT_POINT":"$BOARD_TESTDIR/work",
> >
> >              "FILE_SIZE":"2M",
> >
> > -            "TESTS":"'-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9'"
> >
> > +            "TESTS":"-i 0 -i 1 -i 2 -i 6 -i 7 -i 8 -i 9"
> >
> >          }
> >
> >      }
> >
> > }
> >
> > --
> >
> > 2.17.1
> >
> >