Re: [Fuego] [fuego-core 3/7] testplan_smoketest.json: ftc fails to add job for tesplan_smoketest

<[email protected]> Thu, 22 Jul 2021 18:49:40 +0000
Newsgroups dev.linux.lists.fuego
Message-ID <BYAPR13MB25030A06BFA46EA78B533084FDE49@BYAPR13MB2503.namprd13.prod.outlook.com>

> -----Original Message-----
> From: [email protected] <[email protected]>
> 
> From: yoshida toshiko <[email protected]>
> 
>  add missing comma after Benchmark.dbench4
> 
>  e.g: ftc add-jobs -b local -p testplan_smoketest
> 
> Signed-off-by: venkata pyla <[email protected]>
> ---
>  overlays/testplans/testplan_smoketest.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/overlays/testplans/testplan_smoketest.json b/overlays/testplans/testplan_smoketest.json
> index 8c856c1..4bbbe4f 100644
> --- a/overlays/testplans/testplan_smoketest.json
> +++ b/overlays/testplans/testplan_smoketest.json
> @@ -12,7 +12,7 @@
>              "testName": "Benchmark.Dhrystone"
>          },
>          {
> -            "testName": "Benchmark.dbench4"
> +            "testName": "Benchmark.dbench4",
>              "timeout": "40m"
>          },
>          {
> --
> 2.20.1
> 

FYI - the standalone testplans are now deprecated.
The new method of doing this is with a Functional.batch job, like so:
 $ ftc add-jobs -b local -t batch_smoketest

The 'batch' jobs have a testplan embedded in them (in json format
as a HERE document in the fuego_test.sh script for the test.

However, standalone testplans are still supported for backwards compatibility,
and this *is* a bug, so I have applied this.

Thanks!
 -- Tim