Re: [Fuego] fixes for the linaro and rt tests
<[email protected]> Fri, 20 Aug 2021 19:57:21 +0000
| Newsgroups | dev.linux.lists.fuego |
|---|---|
| Message-ID | <BYAPR13MB2503A930996BF7445D992A80FDC19@BYAPR13MB2503.namprd13.prod.outlook.com> |
I'm consolidating feedback into a single message to save time. > -----Original Message----- > From: Daniel Sangorrin <[email protected]> > > Hi Tim > > Please consider merging these patches. > > [PATCH 1/4] linaro: localhost does not require ssh > > This ones is self explanatory (no SSH if you use the local board) This looks OK. I'm wondering if there's another way to detect a local operation. Can we check the TRANSPORT (e.g. if [ $TRANSPORT = "local" ] ...)? Checking the network address seems a bit iffy. > > [PATCH 2/4] linaro: update to python3 > > This one uses pip3 because the upstream python scripts are for > python3 now. This seems fine. > > I thought about adding the dependencies to the Docker install > scripts, but since the requirements are in the upstream repository > I thought it is fine leaving them as they are (you can always > install them in advance and then skip this phase) > > [PATCH 3/4] hackbench: fix the chart config file > > I think this was some copy paste file, which is fixed now. > Looks good. > [PATCH 4/4] rt: search for the binary if the build phase is skipped > > This are all very similar fixes where we enable support for > running binaries that already exist on the board's file system. > For example, because you install rt-tests via apt-get and then > you skipped the Fuego build phase. Interesting idea, and it will save some time. However, the patch, as is, doesn't work on a remote board. I'll respond to that one with some inline comments. -- Tim