Re: [Fuego] [PATCH 3/4] hackbench: fix the chart config file

Thanks Tim, chart_type "measure_plot" sounds better indeed.

> -----Original Message-----
> From: [email protected] <[email protected]>
> Sent: Friday, August 27, 2021 9:33 AM
> To: sangorrin daniel(サンゴリン ダニエル □ＳＷＣ◯ＡＣＴ) <[email protected]>
> Cc: [email protected]; nguyen dat tho(ＴＳＤＶ Ｅｎｇ　１) <[email protected]>
> Subject: RE: [PATCH 3/4] hackbench: fix the chart config file
> 
> OK - I spoke too quickly on this one also.
> 
> See comments inline below.
> 
> > -----Original Message-----
> > From: Daniel Sangorrin <[email protected]>
> >
> > From: Nguyen Dat Tho <[email protected]>
> >
> > Signed-off-by: Nguyen Dat Tho <[email protected]>
> > Signed-off-by: Daniel Sangorrin <[email protected]>
> > ---
> >  tests/Benchmark.hackbench/chart_config.json | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/Benchmark.hackbench/chart_config.json b/tests/Benchmark.hackbench/chart_config.json
> > index 2f58df8..f5ca3e4 100644
> > --- a/tests/Benchmark.hackbench/chart_config.json
> > +++ b/tests/Benchmark.hackbench/chart_config.json
> > @@ -1,3 +1,3 @@
> >  {
> > -        "hackbench":["hackbench"]
> > +        "chart_type": "testset_summary_table"
> 
> This chart_config was indeed broken.  Thanks for catching that.
> However, since this is a benchmark, I prefer for the 'off-the-shelf'
> chart_type to be "measure_plot".
> 
> I applied this patch, but with "measure_plot" instead of "testset_summary_table"
> as the chart_type.
> 
> If you have a reason you'd prefer testset_summary_table over measure_plot,
> please let me know and we can discuss it.
> 
> Thanks,
>  -- Tim
> 
> >  }
> > --
> > 2.17.1
> >