Re: [PATCH v6 4/6] fuse: support registered buffer pools in io-uring

On Thu, Aug 13, 2026 at 2:09 PM Bernd Schubert <[email protected]> wrote:
>
> > diff --git a/include/uapi/linux/fuse.h b/include/uapi/linux/fuse.h
> > index f7173b5d4321..07d12f1c55bb 100644
> > --- a/include/uapi/linux/fuse.h
> > +++ b/include/uapi/linux/fuse.h
> > @@ -246,6 +246,7 @@
> >   *  - add FUSE_HAS_IO_URING_BUFPOOL
> >   *  - add fuse_uring_cmd_req bufpool struct
> >   *  - add bufpool offset field to fuse_uring_ent_in_out struct
> > + *  - add FUSE_URING_REGISTERED_BUFPOOL flag
> >   */
> >
> >  #ifndef _LINUX_FUSE_H
> > @@ -1310,6 +1311,9 @@ enum fuse_uring_cmd {
> >       FUSE_IO_URING_CMD_ADD_BUFPOOL = 4,
> >  };
> >
> > +/* fuse_uring_cmd_req flags for FUSE_IO_URING_CMD_ADD_BUFPOOL */
> > +#define FUSE_URING_REGISTERED_BUFPOOL        (1 << 0)
> > +
> >  /**
> >   * In the 80B command area of the SQE.
> >   */
>
>
> I would personally prefer to avoid FUSE_URING_ADD_BUFPOOL_FLAGS and to
> use IORING_URING_CMD_FIXED, unless there is a really compelling reason
> to have a 2nd flag, but I don't have a strong opinion about it.
>
> Reviewed-by: Bernd Schubert <[email protected]>

Happy to remove the flag then for v7. Thanks for reviewing the patches.

Thanks,
Joanne