Re: [PATCH] fuse: Fix the condition to enable over-io-uring

On 8/21/26 14:28, Bernd Schubert via B4 Relay wrote:
> From: Bernd Schubert <[email protected]>
> 
> I had accidentally used "&&" instead of "||" and totally broken
> the intention of the condition. This has several implications
> 

[...]

>  	/* Once a connection has io-uring enabled on it, it can't be disabled */
> -	if (!enable_uring && !fch->io_uring) {
> +	if (!enable_uring || !fch->io_uring) {
>  		pr_info_ratelimited("fuse-io-uring is disabled\n");
>  		return -EOPNOTSUPP;
>  	}
> @@ -1248,13 +1255,6 @@ int fuse_uring_cmd(struct io_uring_cmd *cmd, unsigned int issue_flags)
>  	if (!fch->connected)
>  		return -ENOTCONN;
>  
> -	/*
> -	 * fuse_uring_register() needs the ring to be initialized,
> -	 * we need to know the max payload size
> -	 */
> -	if (!fch->initialized)
> -		return -EAGAIN;
> -
>  	switch (cmd_op) {
>  	case FUSE_IO_URING_CMD_REGISTER:
>  		err = fuse_uring_register(cmd, issue_flags, fch);
Sorry, actually we need a v2, besides that forgot to add stable@, this
would also allow to disable io-uring for existing connections.