Re: [PATCH 06/14] organgefs: use inode_update_timestamps directly
Jan Kara <[email protected]>
| Newsgroups | dev.linux.lists.gfs2,org.infradead.lists.linux-mtd,org.kernel.vger.io-uring,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <sdgytii6x2ccqsxkocafhojt6h75n3e4kjdofasgo53mcgfc53@um6nkgxw2wt2> |
On Fri 14-11-25 07:26:09, Christoph Hellwig wrote: > Orangefs has no i_version handling and __orangefs_setattr already > explicitly marks the inode dirty. So instead of the using > the flags return value from generic_update_time, just call the > lower level inode_update_timestamps helper directly. > > Signed-off-by: Christoph Hellwig <[email protected]> Besides the typo the change looks good to me. Feel free to add: Reviewed-by: Jan Kara <[email protected]> Honza > --- > fs/orangefs/inode.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c > index a01400cd41fd..55f6c8026812 100644 > --- a/fs/orangefs/inode.c > +++ b/fs/orangefs/inode.c > @@ -878,7 +878,9 @@ int orangefs_update_time(struct inode *inode, int flags) > > gossip_debug(GOSSIP_INODE_DEBUG, "orangefs_update_time: %pU\n", > get_khandle_from_ino(inode)); > - flags = generic_update_time(inode, flags); > + > + flags = inode_update_timestamps(inode, flags); > + > memset(&iattr, 0, sizeof iattr); > if (flags & S_ATIME) > iattr.ia_valid |= ATTR_ATIME; > -- > 2.47.3 > -- Jan Kara <[email protected]> SUSE Labs, CR