Re: [PATCH 09/14] fs: factor out a mark_inode_dirty_time helper
Christoph Hellwig <[email protected]>
| Newsgroups | dev.linux.lists.gfs2,org.infradead.lists.linux-mtd,org.kernel.vger.io-uring,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Nov 24, 2025 at 02:22:59PM +0100, Jan Kara wrote: > What I find a bit concerning here is that mark_inode_dirty_time() takes a > different kind of flags than __mark_inode_dirty() so it's relatively easy > to confuse. Proper typing of 'flags' would be nice here but it's a bit > cumbersome to do in C so I'm not sure if it's worth it for this relatively > limited use. So I guess feel free to add: Adding a __bitwise annotation for the S_ flags seems easy enough as there's not a whole lot of variables/arguments of that time. I can do that as a follow-on.