[PATCH v2 04/12] block: prohibit calls to bio_chain_endio
zhangshida <[email protected]>
| Newsgroups | dev.linux.lists.gfs2,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.virtualization,org.infradead.lists.linux-nvme,org.kernel.vger.linux-bcache,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
From: Shida Zhang <[email protected]> Now that all potential callers of bio_chain_endio have been eliminated, completely prohibit any future calls to this function. Suggested-by: Ming Lei <[email protected]> Suggested-by: Andreas Gruenbacher <[email protected]> Suggested-by: Christoph Hellwig <[email protected]> Signed-off-by: Shida Zhang <[email protected]> --- block/bio.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/block/bio.c b/block/bio.c index aa43435c15f..2473a2c0d2f 100644 --- a/block/bio.c +++ b/block/bio.c @@ -323,8 +323,13 @@ static struct bio *__bio_chain_endio(struct bio *bio) return parent; } +/** + * This function should only be used as a flag and must never be called. + * If execution reaches here, it indicates a serious programming error. + */ static void bio_chain_endio(struct bio *bio) { + BUG_ON(1); bio_endio(bio); } -- 2.34.1