Re: [PATCH v2 12/12] nvmet: use bio_chain_and_submit to simplify bio chaining
Stephen Zhang <[email protected]>
| Newsgroups | dev.linux.lists.gfs2,dev.linux.lists.ntfs3,dev.linux.lists.nvdimm,dev.linux.lists.virtualization,org.infradead.lists.linux-nvme,org.kernel.vger.linux-bcache,org.kernel.vger.linux-block,org.kernel.vger.linux-kernel,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <CANubcdXJyE6Y5J3C5Zgc1jA7qSXk+_Hb0pm8Q-8cTb3Z_eM4sA@mail.gmail.com> |
zhangshida <[email protected]> 于2025年11月28日周五 16:33写道： > > From: Shida Zhang <[email protected]> > > Replace repetitive bio chaining patterns with bio_chain_and_submit. > Note that while the parameter order (prev vs new) differs from the > original code, the chaining order does not affect bio chain > functionality. > > Signed-off-by: Shida Zhang <[email protected]> > --- > drivers/nvme/target/io-cmd-bdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c > index 8d246b8ca60..4af45659bd2 100644 > --- a/drivers/nvme/target/io-cmd-bdev.c > +++ b/drivers/nvme/target/io-cmd-bdev.c > @@ -312,8 +312,7 @@ static void nvmet_bdev_execute_rw(struct nvmet_req *req) > opf, GFP_KERNEL); > bio->bi_iter.bi_sector = sector; > > - bio_chain(bio, prev); > - submit_bio(prev); > + bio_chain_and_submit(prev, bio); > } > My apologies. I think the order really matters here, will drop this patch. Thanks, shida > sector += sg->length >> 9; > -- > 2.34.1 >