Re: [PATCH 04/11] fat: cleanup the flags for fat_truncate_time
OGAWA Hirofumi <[email protected]>
| Newsgroups | dev.linux.lists.gfs2,org.infradead.lists.linux-mtd,org.kernel.vger.io-uring,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-xfs |
|---|---|
| Message-ID | <[email protected]> |
OGAWA Hirofumi <[email protected]> writes: > Christoph Hellwig <[email protected]> writes: > >> Fat only has a single on-disk timestamp covering ctime and mtime. Add >> fat-specific flags that indicate which timestamp fat_truncate_time should >> update to make this more clear. This allows removing no-op >> fat_truncate_time calls with the S_CTIME flag and prepares for removing >> the S_* flags. >> >> Signed-off-by: Christoph Hellwig <[email protected]> > > This breaks fat_update_time() by calling fat_truncate_time() with old > S_* flags (later patch looks like fixing though). Please add the commit > comment about it, or fix it in this patch. > > Thanks. Ah, I was overlooking that new value is using same value with S_*. So Acked-by: OGAWA Hirofumi <[email protected]> Thanks. -- OGAWA Hirofumi <[email protected]>