Re: [PATCH 1/6] nfs: properly disallow delegation requests on directories
Christoph Hellwig <[email protected]>
| Newsgroups | dev.linux.lists.gfs2,dev.linux.lists.v9fs,org.kernel.vger.ceph-devel,org.kernel.vger.linux-cifs,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs |
|---|---|
| Message-ID | <[email protected]> |
On Wed, Jan 07, 2026 at 09:20:09AM -0500, Jeff Layton wrote: > Checking for S_ISREG() in nfs4_setlease() is incorrect, since that op is > never called for directories. The right way to deny lease requests on > directories is to set the ->setlease() operation to simple_nosetlease() > in the directory file_operations. This fixes generic/786 on NFSv4.2 for me, so: Tested-by: Christoph Hellwig <[email protected]>