Re: [PATCH 00/29] fs: require filesystems to explicitly opt-in to nfsd export support
Amir Goldstein <[email protected]>
| Newsgroups | dev.linux.lists.gfs2,dev.linux.lists.ntfs3,dev.linux.lists.ocfs2-devel,net.sourceforge.lists.linux-f2fs-devel,org.infradead.lists.linux-mtd,org.kernel.vger.ceph-devel,org.kernel.vger.linux-btrfs,org.kernel.vger.linux-cifs,org.kernel.vger.linux-ext4,org.kernel.vger.linux-fsdevel,org.kernel.vger.linux-kernel,org.kernel.vger.linux-nfs,org.kernel.vger.linux-nilfs,org.kernel.vger.linux-unionfs,org.kernel.vger.linux-xfs,org.kvack.linux-mm,org.ozlabs.lists.linux-erofs |
|---|---|
| Message-ID | <CAOQ4uxg+dC1o+6V7Nvxf8UW3H=0OvsGjEe76LNY6q8ZcpGDDJw@mail.gmail.com> |
On Wed, Jan 21, 2026 at 12:56 PM Jeff Layton <[email protected]> wrote: > ... > > But if you really really want to set this new flag on almost every > > export_operations, can I ask that you please set it on EVERY export > > operations, then allow maintainers to remove it as they see fit. > > I think that approach would be much easier to review. > > > > We could probably do that, but I think the main ones that excludes it > are kernfs, pidfs and nsfs. ovl and fuse also have export ops in > certain modes that exclude NFS access, so the flag was left off of > those as well. > For the record, my comments regarding fuse_export_fid_operations and ovl_export_fid_operations variants were purely semantic - it did not make sense to mark them as _STABLE_HANDLE, but it does not matter if you set a flag on those ops, because they do not implement ->fh_to_dentry(), on purpose, they are not exportfs_can_decode_fh() by design. Thanks, Amir.