Re: [PATCH 05/13] Revert "gfs2: Fix use of bio_chain"

(This patch is upstream already.)

On Fri, Jan 23, 2026 at 4:31 PM Andreas Gruenbacher <[email protected]> wrote:
>
> This reverts commit 8a157e0a0aa5143b5d94201508c0ca1bb8cfb941.
>
> That commit incorrectly assumed that the bio_chain() arguments were
> swapped in gfs2.  However, gfs2 intentionally constructs bio chains so
> that the first bio's bi_end_io callback is invoked when all bios in the
> chain have completed, unlike bio chains where the last bio's callback is
> invoked.
>
> Fixes: 8a157e0a0aa5 ("gfs2: Fix use of bio_chain")
> Cc: [email protected]
> Signed-off-by: Andreas Gruenbacher <[email protected]>
> ---
>  fs/gfs2/lops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
> index 97ebe457c00a..d27a0b1080a9 100644
> --- a/fs/gfs2/lops.c
> +++ b/fs/gfs2/lops.c
> @@ -484,7 +484,7 @@ static struct bio *gfs2_chain_bio(struct bio *prev, unsigned int nr_iovecs)
>         new = bio_alloc(prev->bi_bdev, nr_iovecs, prev->bi_opf, GFP_NOIO);
>         bio_clone_blkg_association(new, prev);
>         new->bi_iter.bi_sector = bio_end_sector(prev);
> -       bio_chain(prev, new);
> +       bio_chain(new, prev);
>         submit_bio(prev);
>         return new;
>  }
> --
> 2.52.0
>