Re: [PATCH][next] dlm: Avoid -Wflex-array-member-not-at-end warning
Alexander Aring <[email protected]>
| Newsgroups | dev.linux.lists.gfs2,org.kernel.vger.linux-hardening,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <CAK-6q+i0wNRRhhkBGNs6oP159vCfa40SjbrLPbQ_P1NXv2EmFg@mail.gmail.com> |
Hi, On Fri, Jan 30, 2026 at 4:43 PM Gustavo A. R. Silva <[email protected]> wrote: > > Hi all, > > Who can take this, please? > Sorry, I will take care that it will be queued up for the next dlm pull-request. I just checked again if the flexible array member can be accessed under the current conditions, but I don't see this can be ever the case... otherwise we would access garbage. Thanks. > Thanks > -Gustavo > > On 9/22/25 23:20, Gustavo A. R. Silva wrote: > > -Wflex-array-member-not-at-end was introduced in GCC-14, and we are > > getting ready to enable it, globally. > > > > Move the conflicting declaration to the end of the corresponding > > structure. Notice that `struct dlm_message` is a flexible > > structure, this is a structure that contains a flexible-array > > member. > > > > Fix the following warning: > > > > fs/dlm/dlm_internal.h:609:33: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > > > > Signed-off-by: Gustavo A. R. Silva <[email protected]> Acked-by: Alexander Aring <[email protected]> David Teigland can you please apply this patch to dlm/next so we don't forget it. Thanks - Alex