Re: [PATCH] dlm: use hlist_for_each_entry_srcu for SRCU protected lists

Alexander Aring <[email protected]>
Newsgroups dev.linux.lists.gfs2,org.kernel.vger.linux-kernel
Message-ID <CAK-6q+gW_a4NNsm7OAovoYy+QVNbqfv+9XR8GY7kp7Mv4vysMA@mail.gmail.com>
Hi,

On Fri, Feb 6, 2026 at 12:19 AM lirongqing <[email protected]> wrote:
>
> From: Li RongQing <[email protected]>
>
> The connection and node hash tables in DLM are protected by SRCU, but
> the code currently uses hlist_for_each_entry_rcu() for traversal.
> While this works functionally, it is semantically incorrect and triggers
> warnings when RCU lockdep debugging is enabled, as it expects regular
> RCU read-side critical sections.
>

I noticed this as well and came to the same conclusion that it doesn't
matter, but I do agree we should change that because the API can be
changed even in the non debug case.

So thanks for doing this...

Acked-by: Alexander Aring <[email protected]>

- Alex
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.