[PATCH] dlm: check negative length in dlm_search_rsb_tree
Joseph Qi <[email protected]> Fri, 15 May 2026 15:39:33 +0800
| Newsgroups | dev.linux.lists.gfs2,org.kernel.vger.linux-kernel |
|---|---|
| Message-ID | <[email protected]> |
commit 080e5563f878 only checks for len > DLM_RESNAME_MAXLEN, which does not catch negative values. While the input 'len' can be negative and a negative int passed to memcpy() is implicitly converted to a large size_t, causing a stack buffer overflow on the key[] array. Fix this by also rejecting len <= 0. Signed-off-by: Joseph Qi <[email protected]> --- fs/dlm/lock.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c index c381e1028446..124f68c8e653 100644 --- a/fs/dlm/lock.c +++ b/fs/dlm/lock.c @@ -626,8 +626,10 @@ int dlm_search_rsb_tree(struct rhashtable *rhash, const void *name, int len, struct dlm_rsb **r_ret) { char key[DLM_RESNAME_MAXLEN] = {}; - if (len > DLM_RESNAME_MAXLEN) + + if (len <= 0 || len > DLM_RESNAME_MAXLEN) return -EINVAL; + memcpy(key, name, len); *r_ret = rhashtable_lookup_fast(rhash, &key, dlm_rhash_rsb_params); if (*r_ret) -- 2.39.3